Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema after migrations #84

Closed
wants to merge 1 commit into from
Closed

Conversation

djarecka
Copy link
Member

I've fixed some issues with the reproschema migrate and this is what I got running it for the activities.

@satra @ibevers - let me know what you think

@ibevers
Copy link
Contributor

ibevers commented Jul 15, 2024

It looks good after a cursory inspection, although I probably don't have a deep enough understanding of the version changes to notice more subtle issues.

@yibeichan
Copy link
Collaborator

@djarecka this one migrate the old version to our new pydantic model generated version, right?

GA failed this part, I guess it's because our new version uses id instead of @id

Traceback (most recent call last):
  File "tests/jsonParser.py", line 12, in <module>
    if data["@id"] and data["@id"] != name:
KeyError: '@id'
Error: Process completed with exit code 1.

@yibeichan yibeichan deleted the branch ReproNim:master October 10, 2024 18:45
@yibeichan yibeichan closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants