-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Place containers in yoda-idiomatic spot #121
Conversation
where is syntax error? there seems to be full refactoring on where to place the containers subdataset... and it should be harmoneous with the way we do in the monolythic script we also have in README and then test on CI. Please make description proper and ensure consistency |
7ab05d9
to
106222b
Compare
the "syntax error" actually never made it into the README, my mistake. |
0be752d
to
3ef840b
Compare
README.md
Outdated
--input sourcedata \ | ||
--output . \ | ||
'{inputs}' '{outputs}' participant group -w workdir | ||
'{inputs}' '{outputs}' participant --participant-label sub-02 -w workdir | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whatever you need to change, change in your step by step version, not here!
I believe that your changes to monolythic version lead to some odd CI fails starting to happen (I didn't analyze)
since daily testing performed just fine: https://github.com/ReproNim/containers/actions/runs/9376864122/job/25817510428 I can only repeat again -- do not change original monolythic version, change your step by step to match in terms of commands! |
3ef840b
to
a27bb78
Compare
This works on typhon and CI passes. Doesn't run for me locally, but that is tracked #125 and shouldnt block merge here. |
a27bb78
to
27a5548
Compare
27a5548
to
d61b1e3
Compare
When I wrote this originally I did:
datalad install -d . ///repronim/containers code/containers
But I should have used -s:
datalad install -d . -s ///repronim/containers code/containers