create_singularities: Retry Docker Hub API requests on connection failures/timeouts #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarikoptic
reviewed
Feb 16, 2024
| try: | ||
| return requests.get(url) | ||
| except (requests.ConnectionError, requests.Timeout) as e: | ||
| if (wait := next(sleepiter, None)) is not None: |
There was a problem hiding this comment.
note 2 myself: first use of := in the script, but was added in 3.8 and this script for internal use so should be totally fine
yarikoptic
reviewed
Feb 16, 2024
| @@ -78,7 +79,7 @@ class Builder: | |||
|
|
|||
| @staticmethod | |||
| def get_last_docker_version_tag(dh: str, only_good_versions: bool=False) -> Optional[tuple[str, str]]: | |||
| r = requests.get(f"https://registry.hub.docker.com/v2/repositories/{dh}/tags") | |||
| r = retry_get(f"https://registry.hub.docker.com/v2/repositories/{dh}/tags") | |||
There was a problem hiding this comment.
it seems that there is a "standard" way to get retries done with requests: https://requests.readthedocs.io/en/latest/user/advanced/?highlight=Retry#example-automatic-retries but it seems to be also not that straightforward... so I am ok with this "ad-hoc" solution for now. Thank you!
|
will be tested in battle ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #108.