Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checking scalar dtypes for data alignment before embedding #298

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Fix checking scalar dtypes for data alignment before embedding #298

merged 3 commits into from
Oct 24, 2023

Conversation

druzsan
Copy link
Collaborator

@druzsan druzsan commented Oct 23, 2023

Fixes Renumics/spotlight-pro#234

@github-actions
Copy link

github-actions bot commented Oct 23, 2023 •
edited
Loading

GUI in Chrome

⏳ CI is still running or has failed

Diff to the last main

⏳ CI is still running or has failed

GUI in Firefox

⏳ CI is still running or has failed

Diff to the last main

⏳ CI is still running or has failed

@druzsan
Copy link
Collaborator Author

druzsan commented Oct 24, 2023 

Traceback (most recent call last):
  File "/home/alexander/work/projects/spotlight/spotlight/renumics/spotlight/backend/websockets.py", line 372, in _
    await connection.send_async(response)
  File "/home/alexander/work/projects/spotlight/spotlight/renumics/spotlight/backend/websockets.py", line 180, in send_async
    orjson.dumps(message_data, option=orjson.OPT_SERIALIZE_NUMPY).decode()
TypeError: numpy array is not C contiguous; use ndarray.tolist() in default

@druzsan druzsan merged commit 0bb6ce5 into main Oct 24, 2023
34 checks passed
@druzsan druzsan deleted the fix/234-scalar-columns-not-embeddable branch October 24, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neindochoh neindochoh neindochoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@druzsan @neindochoh