Skip to content

Commit

Permalink
fix: include all key types when searching ACM
Browse files Browse the repository at this point in the history
Otherwise, Certbot's new ECDSA certs aren't returned, and the
lambda will think it's a new cert on every run.

DEVOPS-1815 #review
  • Loading branch information
ataraxia937 committed Jul 29, 2024
1 parent f03501b commit d00ed86
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion function/src/index.py
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def find_existing_cert(domains):

client = boto3.client('acm')
paginator = client.get_paginator('list_certificates')
iterator = paginator.paginate(PaginationConfig={'MaxItems':1000})
iterator = paginator.paginate(PaginationConfig={'MaxItems':1000},Includes={'keyTypes': ['RSA_1024', 'RSA_2048', 'RSA_3072', 'RSA_4096', 'EC_prime256v1', 'EC_secp384r1', 'EC_secp521r1']})

for page in iterator:
for cert in page['CertificateSummaryList']:
Expand Down

0 comments on commit d00ed86

Please sign in to comment.