Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix-links behavior due to a problem with external links substitution #78

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

luca-bellenghi
Copy link
Member

Problem is that if we change testurl.it with correcturl.it on a link ct
the subs it's always changing with a site relative domain.

eg.
testurl.it/testA will be always changed with /${portal_url}/resolveuid/1234567890
with 1234567890 the UID of testA.

if correcturl.it it's a different site this behavior will brake the link

@luca-bellenghi luca-bellenghi requested review from mamico and cekk October 9, 2023 08:38
@arsenico13
Copy link
Member

I totally agree with this PR.

This change avoid the mentioned problem and let us use this utility-view for a lot a use cases (like the one in which we discovered this bug).

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6481104628

  • 1 of 8 (12.5%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 62.429%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/redturtle/volto/browser/fix_links.py 1 8 12.5%
Totals Coverage Status
Change from base Build 6469968137: -0.3%
Covered Lines: 766
Relevant Lines: 1227

💛 - Coveralls

@luca-bellenghi luca-bellenghi merged commit 2726741 into master Oct 11, 2023
17 checks passed
@luca-bellenghi luca-bellenghi deleted the correct_fix_links_behavior branch October 11, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants