Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manager validity dates restrictions + Add booking date validation (didn’t exist before) #213

Merged
merged 8 commits into from
Nov 22, 2024
Merged

Manager validity dates restrictions + Add booking date validation (didn’t exist before) #213

merged 8 commits into from
Nov 22, 2024

Conversation

folix-01
Copy link
Member

@folix-01 folix-01 commented Aug 19, 2024 •
edited
Loading

  • Add possibility to restrict also a Bookings Manager by the validity dates of a Booking Folder.
  • Add validity dates checks during the booking creation. Actually is not considered so u can create booking for the every date you want

@folix-01 folix-01 requested review from mamico and cekk August 19, 2024 10:24
@folix-01 folix-01 mentioned this pull request Aug 19, 2024
Open
@coveralls
Copy link

coveralls commented Aug 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11974214186

Details

  • 32 of 33 (96.97%) changed or added relevant lines in 3 files are covered.
  • 14 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 75.57%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/redturtle/prenotazioni/adapters/booker.py 10 11 90.91%
Files with Coverage Reduction New Missed Lines %
src/redturtle/prenotazioni/browser/prenotazioni_context_state.py 6 86.38%
src/redturtle/prenotazioni/utilities/dateutils.py 8 51.02%
Totals Coverage Status
Change from base Build 11253204728: -0.1%
Covered Lines: 4111
Relevant Lines: 5440
💛 - Coveralls

@folix-01 folix-01 requested a review from mamico August 22, 2024 12:21
@folix-01 folix-01 self-assigned this Aug 26, 2024
@folix-01 folix-01 changed the title Manager validity dates restrictions + Add validity dates controls (didn’t exist before) Manager validity dates restrictions + Add validity dates validation (didn’t exist before) Sep 18, 2024
@folix-01 folix-01 changed the title Manager validity dates restrictions + Add validity dates validation (didn’t exist before) Manager validity dates restrictions + Add booking date validation (didn’t exist before) Sep 18, 2024
@folix-01 folix-01 force-pushed the manager_dates_restrictions branch from 418aaf3 to 3805db4 Compare November 22, 2024 14:12
@folix-01 folix-01 merged commit 2d1e030 into main Nov 22, 2024
12 checks passed
@folix-01 folix-01 deleted the manager_dates_restrictions branch November 22, 2024 15:23
@folix-01 folix-01 restored the manager_dates_restrictions branch November 22, 2024 15:23
@folix-01 folix-01 deleted the manager_dates_restrictions branch November 22, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giuliaghisini giuliaghisini giuliaghisini left review comments

@cekk cekk Awaiting requested review from cekk

@mamico mamico Awaiting requested review from mamico

Assignees

@folix-01 folix-01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@folix-01 @coveralls @mamico @giuliaghisini