Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Booking canceled message + wf states translate #207

Merged
merged 5 commits into from
May 22, 2024

Conversation

folix-01
Copy link
Member

No description provided.

@folix-01 folix-01 requested a review from cekk May 21, 2024 15:32
@coveralls
Copy link

coveralls commented May 21, 2024

Pull Request Test Coverage Report for Build 9177329581

Details

  • 53 of 83 (63.86%) changed or added relevant lines in 11 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 75.461%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/redturtle/prenotazioni/behaviors/booking_folder/notifications/appio/init.py 6 8 75.0%
src/redturtle/prenotazioni/behaviors/booking_folder/notifications/appio/notfication_appio_message.py 7 9 77.78%
src/redturtle/prenotazioni/behaviors/booking_folder/notifications/sms/message.py 7 9 77.78%
src/redturtle/prenotazioni/behaviors/booking_folder/notifications/email/events.py 2 7 28.57%
src/redturtle/prenotazioni/behaviors/booking_folder/notifications/appio/events.py 3 9 33.33%
src/redturtle/prenotazioni/behaviors/booking_folder/notifications/sms/events.py 3 9 33.33%
src/redturtle/prenotazioni/behaviors/booking_folder/notifications/email/notification_email_message.py 7 14 50.0%
Files with Coverage Reduction New Missed Lines %
src/redturtle/prenotazioni/behaviors/booking_folder/notifications/sms/adapters.py 1 84.0%
Totals Coverage Status
Change from base Build 9171405936: -0.2%
Covered Lines: 3970
Relevant Lines: 5261

💛 - Coveralls

@folix-01 folix-01 requested a review from cekk May 22, 2024 07:24
@folix-01 folix-01 merged commit a8b9d3e into main May 22, 2024
10 checks passed
@mamico
Copy link
Contributor

mamico commented May 23, 2024

@cekk @folix-01 quando una modifica è breaking (questa mi sembra di capire, fatta così, lo è) va scritto nel changelog e gestita con un incremento della major. Vedo ora io, se possibile gestire retrcompatibilità e lasciarla come patch.

mamico added a commit that referenced this pull request May 23, 2024
@folix-01
Copy link
Member Author

@cekk @folix-01 quando una modifica è breaking (questa mi sembra di capire, fatta così, lo è) va scritto nel changelog e gestita con un incremento della major. Vedo ora io, se possibile gestire retrcompatibilità e lasciarla come patch.

No no, niente retrocompatibilita qui, booking_state_label è il label, frontend deve leggere booking_state per il mapping fin dall'inizio. Per quanto riguarda magior, sono d'accordo.

@folix-01 folix-01 self-assigned this Aug 26, 2024
@folix-01 folix-01 deleted the booking_canceled_message branch August 26, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants