Add hidden booking types #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamico
requested changes
Oct 11, 2023
Solved, thanks |
mamico
reviewed
Oct 11, 2023
Comment on lines
19
to
21
| for index, type in enumerate(deepcopy(res.get("booking_types", {}))): | ||
| if type.get("hidden"): | ||
| del res["booking_types"][index] |
There was a problem hiding this comment.
Suggested change
| for index, type in enumerate(deepcopy(res.get("booking_types", {}))): | |
| if type.get("hidden"): | |
| del res["booking_types"][index] | |
| if res.get("booking_types"): | |
| res["booking_types"] = [ | |
| t for t in res["booking_types"] if not t.get("hidden") | |
| ] |
There was a problem hiding this comment.
Solved, thanks for suggestions
There was a problem hiding this comment.
Ah ok, I could even commit the suggestion directly :D
|
@folix-01 fix tests please |
It seems to be the coverage run problems, re-runned all test jobs |
folix-01
force-pushed
the
hidden_booking_types
branch
from
92ac6d5 to
a6fd1b0
Compare
Pull Request Test Coverage Report for Build 6496999025
💛 - Coveralls |
cekk
requested changes
Oct 13, 2023
src/redturtle/prenotazioni/restapi/serializers/adapters/prenotazioni_folder.py
Show resolved
Hide resolved
src/redturtle/prenotazioni/tests/test_prenotazioni_folder_serializer.py
Outdated
Show resolved
Hide resolved
src/redturtle/prenotazioni/tests/test_prenotazioni_folder_serializer.py
Outdated
Show resolved
Hide resolved
| data["morning_end"] = "1000" | ||
| self.folder_prenotazioni.week_table = week_table | ||
|
|
||
| def test_hidden_type_is_not_shown(self): |
There was a problem hiding this comment.
qui farei due test a seconda del permesso che ha l'utente
cekk
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we are going to have a possibility to use the hidden booking types which can be used only by the operator side