Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

booking info #41

Merged
merged 7 commits into from
Aug 6, 2024
Merged

booking info #41

merged 7 commits into from
Aug 6, 2024

Conversation

mamico
Copy link
Contributor

@mamico mamico commented Jul 31, 2024

qui la chiamata @booking/<booking_id> torna informazioni di dettaglio che prima non tornava (folder, ufficio, ...)

rispetto all'implementazione precedente queste differenze:

  • UID (diventa booking_id),
  • @type (sempre 'Prenotazione'),
  • gate (diventa booking_gate),
  • id (ultimo pezzo dell'URL),
  • staff_notes (usato?)
  • booking_folder_uid (['booking_folder']['uid'])
  • notify_on_confirm (usato?)

per compatibilità potrebbero essere tutti riportati, mi interessava però verificare se nel frontend sono usati o meno.

@mamico mamico requested a review from SaraBianchi July 31, 2024 10:38
@coveralls
Copy link

coveralls commented Jul 31, 2024

Pull Request Test Coverage Report for Build 10210720812

Details

  • 44 of 47 (93.62%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.7%) to 87.065%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/design/plone/ioprenoto/restapi/services/booking/get.py 24 27 88.89%
Totals Coverage Status
Change from base Build 9912826523: 1.7%
Covered Lines: 350
Relevant Lines: 402

💛 - Coveralls

@SaraBianchi
Copy link

  • staff_notes è da rimettere
  • notify_on_confirm è da rimettere

il resto mi sembra ok

@mamico
Copy link
Contributor Author

mamico commented Jul 31, 2024

staff_notes abbiamo visto c'era già, notify_on_confirm aggiunto

@mamico mamico marked this pull request as ready for review July 31, 2024 23:02
@mamico
Copy link
Contributor Author

mamico commented Aug 1, 2024

aggiunti anche gli altri campi per retrocomaptibilità

aggiunti gli stessi valori anche come ritorno della POST (add booking)

@mamico mamico merged commit c8bbfe2 into main Aug 6, 2024
11 checks passed
@mamico mamico deleted the booking_info branch August 6, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants