Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor rest service to simplify inheritance #39

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

luca-bellenghi
Copy link
Member

Mi serve questa piccola modifica perchè per le integrazioni occorre fare delle estensioni dei service. in questo modo mi basta estendere la classe originale e ridefinire un eventuale CT da cercare.
Al lato pratico non cambia nulla

@luca-bellenghi luca-bellenghi requested review from mamico and cekk April 12, 2024 12:52
@luca-bellenghi luca-bellenghi marked this pull request as draft April 12, 2024 12:53
@mamico
Copy link
Contributor

mamico commented Apr 12, 2024

Mi serve questa piccola modifica perchè per le integrazioni occorre fare delle estensioni dei service. in questo modo mi basta estendere la classe originale e ridefinire un eventuale CT da cercare. Al lato pratico non cambia nulla

Ok per me.

Più elegante cambiare la query e mettere una query su object_provides e fare in modo che i differenti CT implementino una interfaccia comune. A quel punto non serve neanche la tua personalizzazione

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8658587460

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 85.434%

Totals Coverage Status
Change from base Build 8687658259: 0.04%
Covered Lines: 305
Relevant Lines: 357

💛 - Coveralls

@luca-bellenghi luca-bellenghi marked this pull request as ready for review April 22, 2024 07:23
@luca-bellenghi luca-bellenghi merged commit 730c5a5 into main Apr 22, 2024
8 checks passed
@luca-bellenghi luca-bellenghi deleted the refactor_rest_service branch April 22, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants