Fix: term values must be unique in booking_type vocabulary (#35)

RedTurtle · Jan 25, 2024 · e84f250 · e84f250
1 parent 7e740f5
commit e84f250
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -4,6 +4,9 @@ Changelog
 1.2.2 (unreleased)
 ------------------
 
+- Fix: term values must be unique in booking_type vocabulary
+  [mamico]
+
 - Workaround per booking_type con caratteri encodati due volte
   [mamico]
 

diff --git a/src/design/plone/ioprenoto/vocabularies/tipologies.py b/src/design/plone/ioprenoto/vocabularies/tipologies.py
@@ -33,12 +33,11 @@ def __call__(self, context):
                 if prenotazioni_folder and api.user.has_permission(
                     "View", obj=prenotazioni_folder
                 ):
-                    terms.extend(
-                        [
-                            self.booking_type2term(booking_type)
-                            for booking_type in prenotazioni_folder.get_booking_types()
-                        ]
-                    )
+                    for booking_type in prenotazioni_folder.get_booking_types():
+                        term = self.booking_type2term(booking_type)
+                        if term.value not in [t.value for t in terms]:
+                            terms.append(term)
+        terms.sort(key=lambda x: x.title)
         return SimpleVocabulary(terms)