Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some refactoring to improve tests and allow users to access data #1

Merged
merged 6 commits into from
Mar 12, 2024
Merged

Some refactoring to improve tests and allow users to access data #1

merged 6 commits into from
Mar 12, 2024

Conversation

cekk
Copy link
Member

@cekk cekk commented Feb 8, 2024

  • Only managers can access deleted feedbacks.
  • Allow all authenticated users to access @feedback endpoint.
    The endpoint will return only feedbacks on objects that they can edit. This is useful when some editors are enabled only in some subfolders and need to access those feedbacks
  • Improve tests.
  • Install souper.plone to have its control-panel in backend.

@cekk
Copy link
Member Author

cekk commented Mar 6, 2024

@mamico @luca-bellenghi @eikichi18 ping ;)

@cekk cekk merged commit fbb571d into main Mar 12, 2024
5 checks passed
@cekk cekk deleted the cekk_improvements branch March 12, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eikichi18 eikichi18 Awaiting requested review from eikichi18

@mamico mamico Awaiting requested review from mamico

@luca-bellenghi luca-bellenghi Awaiting requested review from luca-bellenghi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cekk