feat: ⛎ Trace Phases #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmcqd
requested review from
favonia and
TOTBWF
and removed request for
favonia
favonia
reviewed
Aug 31, 2022
favonia
reviewed
Aug 31, 2022
|
|
I added a function to map phases as well |
|
Suggestions: (1) add a further |
|
Closed as what we want seems to be #38. More precisely, the default traces are user-facing and should be "coarse". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a notion of
Phases, which each trace is tagged with. These represent phases of compilation/interpretation. When displaying a diagnostic, the user can provide a function to determine which phases they are interested in seeing traces from. For instance, a user might be interested in seeing all evaluation steps, but have no interest in seeing the elaboration process.