Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust agent test fix: #498

Closed

Conversation

galmasi
Copy link

@galmasi galmasi commented Oct 9, 2023

  • The current test harness edits the keylime agent source code to adjust the location of the boot log.
  • The location of the default value for the boot log has migrated from common.rs to config.rs
  • Adding config.rs to the list of locations examined for replacement of boot log location.

/sys/kernel/security/tpm0/binary_bios_measurements -> /var/tmp/binary_bios_measurements

TODO: the rust agent has a testing feature for this; changing source code is considered unnecessary and harmful. Fix later.

… replacement of /sys/kernel/security/tpm0/binary_bios_measurements

Signed-off-by: George Almasi <[email protected]>
@galmasi
Copy link
Author

galmasi commented Oct 9, 2023

Merging this feature should result in keylime/rust-keylime#665 passing packit tests (or at least improve passing score).

@ansasaki
Copy link
Contributor

@galmasi I created #499 addressing the issue, could you please review?

@galmasi
Copy link
Author

galmasi commented Oct 10, 2023

Superseded by #499.

@galmasi galmasi closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants