Updated deprecated API endpoint from /users/self to /users?profile=true #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikasosmium
requested review from
vikasosmium,
Achintya-Chatterjee,
satyam73 and
vinit717
vikasosmium
approved these changes
Dec 8, 2024
|
Instead of creating a new PR, update your code changes in that PR #959 only from next time. |
|
Sir, i would have done the same but there were no changes the tests were failing for some unknown reason. There were no changes i could make in the previous PR. That's why i had to create a new PR |
prakashchoudhary07
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 08 Dec 2024
Developer Name: Hariom Vashista
Issue Ticket Number:-
Fixes: Real-Dev-Squad/todo-action-items#255 repo#2
#923Description:
Add description of the PR here
This PR aims at updating the deprecating API endpoint from /users/self to /users?profile=true
Is Under Feature Flag
Database changes
Breaking changes (If your feature is breaking/missing something please mention pending tickets)
Is Development Tested?
Tested in staging?
Add relevant Screenshot below ( e.g test coverage etc. )
The tests was failing in the previous PR i opened for this same issue for some reason #959. Creating a new PR for this reason. Below is the screenshot for the integration test result now:
