Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Block Tab on Task Page of Status-site #960

Merged
merged 9 commits into from
Oct 24, 2023
Merged

Show Block Tab on Task Page of Status-site #960

merged 9 commits into from
Oct 24, 2023

Conversation

shubhamsinghbundela
Copy link
Contributor

@shubhamsinghbundela shubhamsinghbundela commented Oct 19, 2023 •
edited
Loading

Issue: #937

Description:

  • Added Blocked Tab and blocked status in filter in status site
  • Blocked Tab is under feature flag

Dev Tested:

  • Yes

Feature flag:

  • Yes

Images/video of the change:

8CDTYtfAXU.mp4

Test stats

image image image

@vercel
Copy link

vercel bot commented Oct 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 0:57am

Ajeyakrishna-k
Ajeyakrishna-k previously approved these changes Oct 23, 2023
View reviewed changes
ajoykumardas12
ajoykumardas12 previously approved these changes Oct 23, 2023
View reviewed changes
Ajeyakrishna-k
Ajeyakrishna-k previously approved these changes Oct 23, 2023
View reviewed changes
iamitprakash
iamitprakash previously requested changes Oct 23, 2023
View reviewed changes
Copy link
Member

@iamitprakash iamitprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write proper pR details

@ajoykumardas12
Copy link
Contributor

Sorry @iamitprakash, missed the test stats not provided. Will be mindful of the details in future.

ajoykumardas12
ajoykumardas12 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@ajoykumardas12 ajoykumardas12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@iamitprakash iamitprakash merged commit 0b6dee3 into develop Oct 24, 2023
2 checks passed
@iamitprakash iamitprakash deleted the fix/add-Blocked-tab branch October 24, 2023 10:03
@shubhamsinghbundela shubhamsinghbundela mentioned this pull request Oct 24, 2023
Merged
12 tasks
@shubhamsinghbundela shubhamsinghbundela self-assigned this Oct 25, 2023
@shubhamsinghbundela shubhamsinghbundela mentioned this pull request Oct 25, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ajeyakrishna-k Ajeyakrishna-k Ajeyakrishna-k approved these changes

@ajoykumardas12 ajoykumardas12 ajoykumardas12 approved these changes

@iamitprakash iamitprakash iamitprakash left review comments

Assignees

@shubhamsinghbundela shubhamsinghbundela

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shubhamsinghbundela @ajoykumardas12 @iamitprakash @Ajeyakrishna-k