-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Dashboard Page of Status Site #636
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Apart from @bharati-21 comments things looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hey @fakhruddinkw the designs will be taken up in the future once the design team gets us the design |
Title: Improve Dashboard Page of Status Site
issue: #581
Introduction
This pull request focuses on enhancing the Dashboard page of the Status Site project. It involves removing unused code, improving the responsiveness of the search bar component, and adding tests to ensure reliable functionality. The changes aim to improve the user experience and maintainability of the Dashboard page.
Feature Changes
Remove Unused Code:
Fix Responsive Search Bar Component:
Add enabled and disabled styles to the search button:
Add Tests:
Tech Stack
The implementation is based on the Next.js framework, utilizing its features and benefits for efficient development and rendering of the Status Site project.
Product Name
Status Site
Impact
The proposed changes will have the following impact:
Video before changes:
Screencast.from.16-06-23.04.44.06.PM.IST.mp4
Video after changes:
Screencast.from.17-06-23.01.40.21.PM.IST.mp4
Request for Feedback
Reviewers are kindly requested to provide feedback on the proposed changes. Specifically, we would appreciate insights on the effectiveness of unused code removal, the responsiveness of the search bar component, and the quality of the added tests. Additionally, any suggestions for further improvement are welcome.
Thank you for your time and valuable feedback.