Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Dashboard Page of Status Site #636

Merged
merged 9 commits into from
Jun 22, 2023

Conversation

RitikJaiswal75
Copy link
Contributor

@RitikJaiswal75 RitikJaiswal75 commented Jun 16, 2023

Title: Improve Dashboard Page of Status Site

issue: #581

Introduction

This pull request focuses on enhancing the Dashboard page of the Status Site project. It involves removing unused code, improving the responsiveness of the search bar component, and adding tests to ensure reliable functionality. The changes aim to improve the user experience and maintainability of the Dashboard page.

Feature Changes

  1. Remove Unused Code:

    • Identify and remove any unused code or components from the Dashboard page to optimize the codebase and improve performance.
  2. Fix Responsive Search Bar Component:

    • Enhance the responsiveness of the search bar component on the Dashboard page to ensure it behaves correctly on different devices and screen sizes.
  3. Add enabled and disabled styles to the search button:

    • Add styles to make the search button visually enabled and disabled
  4. Add Tests:

    • Implement appropriate unit tests to verify the functionality of the Dashboard page and ensure its stability.

Tech Stack

The implementation is based on the Next.js framework, utilizing its features and benefits for efficient development and rendering of the Status Site project.

Product Name

Status Site

Impact

The proposed changes will have the following impact:

  • Improved performance by removing unused code and optimizing the Dashboard page.
  • Enhanced user experience through a responsive search bar component that works seamlessly on various devices.
  • Increased reliability and stability of the Dashboard page by adding appropriate tests.
  • Improved maintainability and readability of the codebase.

Video before changes:

Screencast.from.16-06-23.04.44.06.PM.IST.mp4

Video after changes:

Screencast.from.17-06-23.01.40.21.PM.IST.mp4

Request for Feedback

Reviewers are kindly requested to provide feedback on the proposed changes. Specifically, we would appreciate insights on the effectiveness of unused code removal, the responsiveness of the search bar component, and the quality of the added tests. Additionally, any suggestions for further improvement are welcome.

Thank you for your time and valuable feedback.

@vercel
Copy link

vercel bot commented Jun 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 11:49am

@RitikJaiswal75 RitikJaiswal75 self-assigned this Jun 16, 2023
@RitikJaiswal75 RitikJaiswal75 changed the title format code for better responsive design Improve Dashboard Page of Status Site Jun 16, 2023
shubham-y
shubham-y previously approved these changes Jun 17, 2023
TanishqSingla
TanishqSingla previously approved these changes Jun 17, 2023
TanishqSingla
TanishqSingla previously approved these changes Jun 17, 2023
@prakashchoudhary07
Copy link
Contributor

Apart from @bharati-21 comments things looks good.

Copy link
Contributor

@bharati-21 bharati-21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fakhruddinkw
Copy link
Contributor

Just a design suggestions:
Instead of having a search button, what if we have a search icon next to our search bar when the width goes below a certain number?

Example:
search

@RitikJaiswal75
Copy link
Contributor Author

Just a design suggestions:
Instead of having a search button, what if we have a search icon next to our search bar when the width goes below a certain number?

hey @fakhruddinkw the designs will be taken up in the future once the design team gets us the design

@RitikJaiswal75 RitikJaiswal75 merged commit e5fbd79 into develop Jun 22, 2023
@RitikJaiswal75 RitikJaiswal75 deleted the feat/progress-dashboard branch June 22, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants