fixed mine component issue #414
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kshitij430 is attempting to deploy a commit to the RDS-Team Team on Vercel. A member of the Team first needs to authorize it. |
ivinayakg
reviewed
Feb 9, 2023
Comment on lines
+55
to
+58
| tasks.length > 0 && <div>{CardList(tasks)}</div> | ||
| } | ||
| { | ||
| response?.length == 0 && tasks.length == 0 && <p>No Tasks Found</p> |
There was a problem hiding this comment.
I checked the code, this response object holds the tasks array right? so, if yes then why are we even checking the state (task state), why not a simple check of response.length > 0 ? {render tasks} : no tasks, do check if you can do this.
heyrandhir
reviewed
Feb 9, 2023
Comment on lines
+37
to
+38
| if (JSON.stringify(response) === "{}") callAPI(); | ||
| if (JSON.stringify(response) !== "{}") setTasks(response); |
There was a problem hiding this comment.
instead of 2 if's could we not add an if else block.
There was a problem hiding this comment.
thank you for pointing it out, will do that.
This was referenced Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes issue #375 .
Earlier I had raised a PR #386 which did not work as intended. Because it had missing "response" as a dependency in the useEffect call.
The issue that needed to solve was, as during the initial render response is an empty object. based on the empty object the
tasks state was getting updated and as "response" was a dependency it kept on going in a loop.
To solve the issue. I added two checks.
To avoid the blinking effect of no tasks found. I had to add checks to see if the response is empty and if the tasks is empty. Only then we can say No tasks found.
Please find the video attached to simulate the working. In the first instance I have used a different url to get the tasks and updated my code accordingly. In the second instance I have used the /self API which for my user returns an empty array.
2023-02-07.00-04-41.mp4