Dev to Main Sync #1293
Merged
Dev to Main Sync #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * feat: added modal for updating task progress - Require users to provide a task update before modifying progress percentage. - Restrict progress updates to tasks with status In Progress only. - Addressed the issue where users could update progress without providing updates or changing task status. - Ensures better task tracking and accountability. * fix: added the missing props * fix: preserve modal styling after task progress update Resolves an issue where the task update modal's styling was reverting to default styles after submitting progress updates. The implementation now maintains consistent styling throughout the update process by properly managing the props on modal state and preventing unintended style resets. * fix: restore progress bar in task details section Reimplements the progress bar in task details section to be visible in both default and dev mode, while ensuring updates are only possible through the task update modal. Progress bar now maintains a read-only state in the details view while remaining interactive in the modal. * Test: progress update flow modal (#1291) * fix: failing tests accroding to the component change * test(TaskUpdateModal): add unit tests for TaskUpdateModal component - Test rendering of modal in open and closed states - Verify functionality of close button - Ensure correct props are passed to ProgressContainer and ProgressForm - Mock dependencies (Modal, ProgressContainer, ProgressForm) for isolation - Validate display of current date * fix: test cases after the component gets changed * fix: improve test coverage for TaskUpdateModal component
Achintya-Chatterjee
requested review from
prakashchoudhary07,
iamitprakash,
yesyash,
tejaskh3 and
vinit717
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
iamitprakash
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date:
7th December, 2024Developer Name: @Achintya-Chatterjee
Issue Ticket Number
PRs going in this sync
Description
Added modal for updating task progress and percentage
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Screen.Recording.2024-12-08.at.23.12.52.mp4
Test Coverage
Screenshot 1
Additional Notes