Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shimmer card component in mine page #1284

Merged
merged 7 commits into from
Nov 27, 2024

Conversation

pankajjs
Copy link
Contributor

@pankajjs pankajjs commented Nov 19, 2024

Date: 20 Nov, 2024

Developer Name: @pankajjs


Issue Ticket Number

Description

This PR fixes the shimmer card component in mine page.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1
shimmer.mp4
Screenshot 2024-11-25 at 11 27 42 PM Screenshot 2024-11-25 at 11 27 53 PM

Test Coverage

Screenshot 1 Screenshot 2024-11-20 at 1 03 29 AM

Additional Information

Design Doc - https://docs.google.com/document/d/1Y-V7ClFjge1c01ErrFpGgmfZJ6wXZCJ7q2SuLDrcEcY/edit?tab=t.0#heading=h.iwhskjpqyzwf

Copy link

vercel bot commented Nov 19, 2024

@pankajjs is attempting to deploy a commit to the RDS-Team Team on Vercel.

A member of the Team first needs to authorize it.

@pankajjs pankajjs marked this pull request as ready for review November 20, 2024 07:38
@VinuB-Dev
Copy link
Contributor

Code looks good.

@VinuB-Dev
Copy link
Contributor

@pankajjs Can you also add mobile view recording / screenshot.

@pankajjs
Copy link
Contributor Author

@pankajjs Can you also add mobile view recording / screenshot.

Added.

@pankajjs
Copy link
Contributor Author

@VinuB-Dev Have you checked the screenshots? If yes, could you approve it?

@pankajjs pankajjs requested a review from VinuB-Dev November 25, 2024 18:37
Copy link
Contributor

@VinuB-Dev VinuB-Dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

@iamitprakash iamitprakash merged commit 406f2eb into Real-Dev-Squad:develop Nov 27, 2024
1 of 2 checks passed
@Achintya-Chatterjee Achintya-Chatterjee mentioned this pull request Nov 28, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: change shimmer ui card in mine page
3 participants