add loading skeleton for user profile in the navbar #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AnujChhikara is attempting to deploy a commit to the RDS-Team Team on Vercel. A member of the Team first needs to authorize it. |
|
Your Github action is failing fix that |
|
Please add the test coverage of the file you have changed |
|
Sorry, I forgot about that. Test coverage of Navbar added now |
yesyash
approved these changes
Oct 9, 2024
vinit717
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 8 Oct, 2024
Developer Name: Anuj Chhikara
Issue Ticket Number
#1268
Description
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Problem Screenshot
Solved Screenshot
Test Coverage
Earlier coverage
Now coverage
Test Results: All tests passed successfully (7/7) for the Navbar component.
Additional Notes
Problem: When navigating the navbar, the user status briefly displays "Login with GitHub" before showing the user data, leading to a confusing experience for users.
Fix: Implemented a loading skeleton to provide a visual indication while the user data is being fetched, ensuring a smoother transition and a clearer user experience.
Impact: This enhancement reduces confusion and improves the overall user experience by clearly indicating that the application is loading user data.