-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Feature Flag for progress updates section in tasks deatails page Status site. #1093
base: develop
Are you sure you want to change the base?
Remove Feature Flag for progress updates section in tasks deatails page Status site. #1093
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide context on import order changes.
Also please provide context on changed tests because the tests didn't seem related to feature flag.
@ajoykumardas12 . I think import order might be changed because of some of the vs code extensions. And can you let me know what should be the import order that needs to maintained. And regarding test changes , as i removed the dev flag related code currently changed tests were failing. So removed the unnecessary tests and modified the needed one. Main changes in tests are because of removal of this piece of code in ProgressDetails component.
And modal related tests are deleted in ProgressDetails.test.tsx because, after the dev flag removal |
I don't think status site has specified import order to follow, unrelated changes to import would be unnecessary though. But, if you want to follow import order, I think first react,nextjs imports, then other libraries, then components, utils, then styles, icons would be good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a working proof after removing the feature flag
Hey @Achintya-Chatterjee , |
In new progress updates view, there was an issue where we were not able to view all details(like Next update, Blockers) for old updates. Is that fixed? cc: @satyam73 |
Details like Next update, blockers were earlier shown in modal. But the new progress update view doesn't have any modal and shows only Title and time in days ago format for old updates. This PR doesn’t intend to fix any bugs. It’s about removing the dev flag in the taskDetails page as Ankush had asked. If this needs to be put on hold until the bug is fixed, please let me know @Ajeyakrishna-k. |
Yep, please have a look at these messages: https://discord.com/channels/673083527624916993/741616265050849282/1194286232071573636 |
Not now I had previously raised PR in which modal can be opened then Ankush told me to expand the card. The PR for modal is here (which is not the requirement now) - #1075 I haven't worked on expanding the card part. |
Date: 26-01-2024
Developer Name: @VinayakaHegade
Issue Ticket Number
closes #1081
Description
Removed feature flag from task detail page in status site.
https://status.realdevsquad.com/tasks/zkvbxo39CByKmND1mx4Y
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Before
After
demo.mp4
Test Coverage
Screenshot 1
Additional Notes