Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Feature Flag for progress updates section in tasks deatails page Status site. #1093

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

VinayakaHegade
Copy link
Contributor

@VinayakaHegade VinayakaHegade commented Jan 26, 2024

Date: 26-01-2024

Developer Name: @VinayakaHegade


Issue Ticket Number

closes #1081

Description

Removed feature flag from task detail page in status site.
https://status.realdevsquad.com/tasks/zkvbxo39CByKmND1mx4Y

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Before

before

After

after

demo.mp4

Test Coverage

Screenshot 1

coverage

Additional Notes

Copy link
Contributor

@ajoykumardas12 ajoykumardas12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide context on import order changes.

Also please provide context on changed tests because the tests didn't seem related to feature flag.

@VinayakaHegade
Copy link
Contributor Author

@ajoykumardas12 . I think import order might be changed because of some of the vs code extensions. And can you let me know what should be the import order that needs to maintained.

And regarding test changes , as i removed the dev flag related code currently changed tests were failing. So removed the unnecessary tests and modified the needed one.

Main changes in tests are because of removal of this piece of code in ProgressDetails component.
<li onClick={openDetails} className={styles['list-item']} data-testid="progress-item" > {getDateFromTimestamp(data.date)} </li>

data-testid="progress-item" was used for querying in ProgressDetails.test.tsx and ProgressCard.test.tsx. So it is the reason for test changes in those two files.

And modal related tests are deleted in ProgressDetails.test.tsx because, after the dev flag removal showProgressDetails state would never become true and modal will not open, so modal tests are deleted.

@ajoykumardas12
Copy link
Contributor

I think import order might be changed because of some of the vs code extensions. And can you let me know what should be the import order that needs to maintained.

I don't think status site has specified import order to follow, unrelated changes to import would be unnecessary though. But, if you want to follow import order, I think first react,nextjs imports, then other libraries, then components, utils, then styles, icons would be good.

@VinayakaHegade VinayakaHegade changed the title Remove Feature Flag from tasks in Status site. Remove Feature Flag from tasks deatails in Status site. Jan 27, 2024
Copy link
Member

@Achintya-Chatterjee Achintya-Chatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a working proof after removing the feature flag

@VinayakaHegade
Copy link
Contributor Author

Can you please add a working proof after removing the feature flag

Hey @Achintya-Chatterjee ,
I have added screen recording of working demo in the screenshots section above.
Can you review it again and check if it can be approved.

@Ajeyakrishna-k
Copy link
Contributor

In new progress updates view, there was an issue where we were not able to view all details(like Next update, Blockers) for old updates. Is that fixed?

cc: @satyam73

@VinayakaHegade
Copy link
Contributor Author

In new progress updates view, there was an issue where we were not able to view all details(like Next update, Blockers) for old updates. Is that fixed?

cc: @satyam73

Details like Next update, blockers were earlier shown in modal. But the new progress update view doesn't have any modal and shows only Title and time in days ago format for old updates.

This PR doesn’t intend to fix any bugs. It’s about removing the dev flag in the taskDetails page as Ankush had asked.

If this needs to be put on hold until the bug is fixed, please let me know @Ajeyakrishna-k.

@VinayakaHegade VinayakaHegade changed the title Remove Feature Flag from tasks deatails in Status site. Remove Feature Flag for progress updates in tasks deatails page Status site. Jan 29, 2024
@VinayakaHegade VinayakaHegade changed the title Remove Feature Flag for progress updates in tasks deatails page Status site. Remove Feature Flag for progress updates section in tasks deatails page Status site. Jan 29, 2024
@Ajeyakrishna-k
Copy link
Contributor

In new progress updates view, there was an issue where we were not able to view all details(like Next update, Blockers) for old updates. Is that fixed?
cc: @satyam73

Details like Next update, blockers were earlier shown in modal. But the new progress update view doesn't have any modal and shows only Title and time in days ago format for old updates.

This PR doesn’t intend to fix any bugs. It’s about removing the dev flag in the taskDetails page as Ankush had asked.

If this needs to be put on hold until the bug is fixed, please let me know @Ajeyakrishna-k.

Yep, please have a look at these messages:

https://discord.com/channels/673083527624916993/741616265050849282/1194286232071573636
https://discord.com/channels/673083527624916993/741616265050849282/1195018552428736642

@satyam73
Copy link
Member

In new progress updates view, there was an issue where we were not able to view all details(like Next update, Blockers) for old updates. Is that fixed?

cc: @satyam73

Not now I had previously raised PR in which modal can be opened then Ankush told me to expand the card.

The PR for modal is here (which is not the requirement now) - #1075

I haven't worked on expanding the card part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Feature Flag from Progress update section task details page in Status site.
5 participants