Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev to main sync #523

Merged
merged 14 commits into from
Nov 24, 2023
Merged

dev to main sync #523

merged 14 commits into from
Nov 24, 2023

Conversation

shubhamsinghbundela
Copy link
Contributor

@shubhamsinghbundela shubhamsinghbundela commented Nov 22, 2023

Not merge this now

Date: 23-11-2023

Developer Name: @shubhamsigdar1 , @sumitd94

Issue Ticket Number:-

PR Number(s):-

Is Under Feature Flag

  • Yes
  • No

Database changes

  • Yes
  • No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

  • Yes
  • No

Is Development Tested?

  • Yes
  • No

Tested in staging?

  • Yes
  • No

Add relevant Screenshot below

Screenshot 2023-11-24 at 3 49 02 PM

dhruv036 and others added 2 commits November 7, 2023 23:28
* Added Open RDS app from my-site

* Removed service and added Test case to verify dialog

* Added Feature flag, Refactored code

* Refactored test cases

* Resolved style and test case

* Refactored style
Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for staging-my ready!

Name Link
🔨 Latest commit 16eeacc
🔍 Latest deploy log https://app.netlify.com/sites/staging-my/deploys/65607842516a8600099a0782
😎 Deploy Preview https://deploy-preview-523--staging-my.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shubhamsinghbundela
Copy link
Contributor Author

shubhamsinghbundela commented Nov 22, 2023

Date: 23-11-2023

Developer Name: @dhruv036

Issue Ticket Number:-

PR Number(s):-

Is Under Feature Flag

  • Yes
  • No

Database changes

  • Yes
  • No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

  • Yes
  • No

Is Development Tested?

  • Yes
  • No

Tested in staging?

  • Yes
  • No

Add relevant Screenshot below

dhruv.video.mp4

@Real-Dev-Squad Real-Dev-Squad deleted a comment from dhruv036 Nov 22, 2023
app/components/mobile-dialog.js Outdated Show resolved Hide resolved
app/controllers/application.js Outdated Show resolved Hide resolved
app/controllers/application.js Outdated Show resolved Hide resolved
app/templates/application.hbs Outdated Show resolved Hide resolved
app/styles/components/mobile-dialog.css Outdated Show resolved Hide resolved
app/styles/components/mobile-dialog.css Outdated Show resolved Hide resolved
app/components/mobile-dialog.hbs Outdated Show resolved Hide resolved
app/components/mobile-dialog.hbs Outdated Show resolved Hide resolved
* Sho a toast on Error in SignOutHandler

* style: fix prettier issues

---------

Co-authored-by: Prakash <[email protected]>
Copy link

cloudflare-workers-and-pages bot commented Nov 22, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 16eeacc
Status: ✅  Deploy successful!
Preview URL: https://8ad22273.my-rds.pages.dev
Branch Preview URL: https://develop.my-rds.pages.dev

View logs

@dhruv036 dhruv036 mentioned this pull request Nov 22, 2023
8 tasks
* naming convention resolved

* naming convention changes

* naming resolved
@sumitd94 sumitd94 dismissed yesyash’s stale review November 24, 2023 10:47

Changes addressed

@prakashchoudhary07 prakashchoudhary07 merged commit 0586e89 into main Nov 24, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants