Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linkedin #566

Closed
wants to merge 6 commits into from
Closed

linkedin #566

wants to merge 6 commits into from

Conversation

DevSoni2022
Copy link
Contributor

@DevSoni2022 DevSoni2022 commented Oct 22, 2023 •
edited
Loading

As get to know new members' site soon deploy on Production,that issue already fixed on new member site

@vercel
Copy link

vercel bot commented Oct 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
members-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 4:02pm
website-members ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 4:02pm

shubhamsinghbundela
shubhamsinghbundela reviewed Oct 26, 2023
View reviewed changes
Copy link

@shubhamsinghbundela shubhamsinghbundela left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge conflict
image

@DevSoni2022
Copy link
Contributor Author

merge conflict image

Merge conflict resolved

@shubhamjaintech
Copy link
Contributor

@DevSoni2022 have we added any test case for this ticket/feature? if not then can we try adding it.?
*I guess this change is similar of your old ticket related to twitter redirect, maybe if you added test case there, then can add similar test case for linkedin redirect. Thank you.

@DevSoni2022
Copy link
Contributor Author

DevSoni2022 commented Oct 26, 2023 •
edited
Loading

@DevSoni2022 have we added any test case for this ticket/feature? if not then can we try adding it.? *I guess this change is similar to your old ticket related to Twitter redirect, maybe if you added a test case there, then can add a similar test case for LinkedIn redirect. Thank you.

Shubham, In my last task, also did not write any test case for specific card test cases already written.
That are working fine SS attached in PR

@shubhamjaintech
Copy link
Contributor

Approved via comment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamsinghbundela shubhamsinghbundela shubhamsinghbundela left review comments

@shubhamjaintech shubhamjaintech shubhamjaintech left review comments

@ankushdharkar ankushdharkar Awaiting requested review from ankushdharkar ankushdharkar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DevSoni2022 @shubhamjaintech @shubhamsinghbundela