enhancement: added shimmer effect #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying dashboard-rds with
|
| Latest commit: |
cb9878e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5b46e91e.dashboard-rds.pages.dev |
| Branch Preview URL: | https://enhancement-removing-extensi.dashboard-rds.pages.dev |
joyguptaa
reviewed
Oct 12, 2024
|
The test Coverage Screenshot is not visible. Please Check. Also tests are failing |
|
|
add it to the Pr description it's still not visible there |
This will be removed eventually
Achintya-Chatterjee
previously approved these changes
Oct 15, 2024
shubhdevelop
previously approved these changes
Oct 15, 2024
Please add coverage screenshot for extension-requests/script.js file as it is not visible in the attached image. |
|
joyguptaa
previously approved these changes
Oct 15, 2024
iamitprakash
requested review from
shubhdevelop,
joyguptaa and
Achintya-Chatterjee
rishirishhh
dismissed stale reviews from joyguptaa, shubhdevelop, and Achintya-Chatterjee
via
121b375
|
update the video in PR, reflecting latest changes |
Screencast.from.16-10-24.12.37.48.PM.IST.webm |
iamitprakash
approved these changes
Oct 16, 2024
Merged
VaibhavSingh8
pushed a commit
that referenced
this pull request
Nov 4, 2024
* enhancement: added shimmer effect * added e2e tests * removed comments from style.css * Update tests.yml This will be removed eventually * Update tests.yml * added uniform design to the card * fixed small error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 12/10/2024
Developer Name: Kavya Rishi
Issue Ticket Number
Description
Currently in the extension requests card when it is loading we see a slight delay in some of the elements being rendered, during that time when those element are being rendered , there is nothing in the UI to show that its being rendered . There is just a blank. This can be seen in the screenshot that i have shared. The data that has already being loaded by the card is inaccessible to the user because of the loading spinner. Hence the loading spinner should be removed and there should be a shimmer in the place of the data that is still being loaded.
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Screencast.from.16-10-24.12.37.48.PM.IST.webm
Test Coverage