Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix online-members page task section #878

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

Mir-SA
Copy link
Contributor

@Mir-SA Mir-SA commented Oct 8, 2024

Date: 08/10/2024

Developer Name: Sameer Supe


Issue Ticket Number

Description

changed a value in script.js which was preventing task section from rendering, also changes a stylesheet value

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1
dasboard-online-page.mp4

Test Coverage

Screenshot 1

image

@Mir-SA Mir-SA force-pushed the fix/online-members branch from db215ed to 4f2cafe Compare October 9, 2024 11:32
Copy link
Member

@vinit717 vinit717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failing tests also Can we show spinner instead of Loading... text

@Mir-SA
Copy link
Contributor Author

Mir-SA commented Oct 10, 2024

Please fix the failing tests

fixed it.

also Can we show spinner instead of Loading... text

@vinit717 sure, should I send it in this pr? or raise another ticket?

@Mir-SA Mir-SA force-pushed the fix/online-members branch from 4f2cafe to aebac5a Compare October 10, 2024 08:12
@Mir-SA Mir-SA requested a review from vinit717 October 10, 2024 08:20
@iamitprakash iamitprakash merged commit 8fd1621 into Real-Dev-Squad:develop Oct 11, 2024
4 checks passed
vinit717 added a commit that referenced this pull request Oct 12, 2024
VaibhavSingh8 pushed a commit that referenced this pull request Nov 4, 2024
changed tasks container details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix online members page
4 participants