Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted Tabs to Dropdown on Discord Users Page #873

Merged
merged 12 commits into from
Nov 21, 2024

Conversation

DepayanMondal
Copy link
Contributor

@DepayanMondal DepayanMondal commented Oct 5, 2024

Date: 12.11.2024

Developer Name: @DepayanMondal


Issue Ticket Number

Description

The Discord Users page previously featured two tabs 'In Discord' and 'Linked Accounts'. I have changed these tabs into a dropdown.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1
Screencast.from.2024-11-12.23-37-39.mp4

Test Coverage

Screenshot 1

image

Additional Notes

@surajmaity1
Copy link

Upload screenshot or video

@satyam73 satyam73 marked this pull request as draft October 19, 2024 14:53
@Achintya-Chatterjee Achintya-Chatterjee marked this pull request as ready for review October 30, 2024 08:38
@DepayanMondal
Copy link
Contributor Author

Upload screenshot or video

updated video and related descriptions

__tests__/users/App.test.js Outdated Show resolved Hide resolved
__tests__/users/applyFilterPagination.test.js Outdated Show resolved Hide resolved
constants.js Outdated Show resolved Hide resolved
users/discord/style.css Outdated Show resolved Hide resolved
@vinit717
Copy link
Member

Do you have approval for this design?
and can you provide me the design/wireframe

@DepayanMondal
Copy link
Contributor Author

Do you have approval for this design? and can you provide me the design/wireframe

Ankush told me to make wireframe for the next tasks, this one he said it's fine since it's a small change.
I'm following this guideline for now https://www.figma.com/design/OSJafX41yQacTzqsaCbX4j/design-system?node-id=1-2&node-type=frame

@vinit717
Copy link
Member

please fix the title of PR

@DepayanMondal DepayanMondal changed the title added dropdown Converted Tabs to Dropdown on Discord Users Page Nov 18, 2024
@DepayanMondal
Copy link
Contributor Author

please fix the title of PR

Changed the PR title to task title

Copy link
Member

@satyam73 satyam73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamitprakash iamitprakash merged commit 2629ec5 into Real-Dev-Squad:develop Nov 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert Tabs to Dropdown on Discord Users Page
6 participants