Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed the datepicker feature in user standup updates and fixed the hover issue on dates #851

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

ANKIT9761
Copy link

Issue on standup dates

Date: 24-09-2024

Developer Name: Ankit Kanyal


Issue Ticket Number

#830

Description

So I have added a datepicker in user standup update section when clicked the user is automatically scrolled to that particular standup date.Also I have fixed hover issues when user hover over standup dates .Previously when user hover over any date hover effect is applied to entire row.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1

image

standup-demo.mp4

Test Coverage

Screenshot 1

Group tests are passing.
image

image

Additional Notes

standup/script.js Outdated Show resolved Hide resolved
Copy link
Member

@vinit717 vinit717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write test for your changes

standup/script.js Outdated Show resolved Hide resolved
Copy link
Member

@vinit717 vinit717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why there is too much changes as your task is related to only standup

@ANKIT9761
Copy link
Author

ANKIT9761 commented Sep 27, 2024

@vinit717

why there is too much changes as your task is related to only standup

After making changes there was an update on develop branch so as stated in contributing.md I pulled those changes and rebased it as we were told to do in the readme.

@vinit717 vinit717 changed the base branch from develop to fix/conflict September 27, 2024 17:06
@vinit717 vinit717 changed the base branch from fix/conflict to develop September 27, 2024 17:06
standup/script.js Outdated Show resolved Hide resolved
__tests__/standup/standup.test.js Outdated Show resolved Hide resolved
__tests__/standup/standup.test.js Outdated Show resolved Hide resolved
__tests__/standup/standup.test.js Show resolved Hide resolved
@ANKIT9761 ANKIT9761 requested a review from vinit717 September 27, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants