Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev to main sync #839

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Dev to main sync #839

merged 5 commits into from
Sep 25, 2024

Conversation

sahsisunny
Copy link
Contributor

@sahsisunny sahsisunny commented Sep 22, 2024

Date: 25th September, 2024

Developer Name: @DeltaDynamo @listiclehub1


Issue Ticket Number

PR's going in this sync

Description

  • Removed the previously next and prev button and added Intersection Observer so that when you reach the bottom of the page the new data is automatically fetched from api and added.
  • Updated Reject Button element tag from

    to

  • Updated CSS to make Application cards have 90% screen width (<500px screen size), 85% screen width (>500px screen size) with max card width of 800px and equal margins on both sides.
  • Updated CSS to add effect on Click / Hover of Accept & Reject Buttons under Applications Card.

Screenshots

RDSTesting.mp4

https://github.com/user-attachments/assets/7b8ed678-9b04-455a-a8c1-efea3052cb9c
https://github.com/user-attachments/assets/2da0f3c4-724b-4c6e-a714-d666b014a940

https://github.com/user-attachments/assets/169e1579-1c3b-46e2-814c-c84a54eb8416

* commit01

* commit2

* commit03

* Run prettier command

* fixed Errors in home.test.js

* fixed the responsiveness of dashboard

* fixed the font weight of description and title

* fixed the dashboard buttons design
@sahsisunny
Copy link
Contributor Author

sahsisunny commented Sep 22, 2024

@Nikhil-Kumar1 Can you please verify your changes in staging and also update the description of this PR?

Staging - https://staging-dashboard.realdevsquad.com/

* Make Application Cards responsive on small screen size & Add Click/Hover Action for Accept/Reject Buttons

* Prettier Run Fix

* Add :is pseduo class for combining :hover and :active states to reduce lines of code

* Resolve change requests
Copy link

cloudflare-workers-and-pages bot commented Sep 22, 2024

Deploying dashboard-rds with  Cloudflare Pages  Cloudflare Pages

Latest commit: d0419b8
Status: ✅  Deploy successful!
Preview URL: https://f99535f3.dashboard-rds.pages.dev
Branch Preview URL: https://develop.dashboard-rds.pages.dev

View logs

vinit717 and others added 2 commits September 23, 2024 00:22
Revert "Improve Dashboard Site Homepage (#817)"

This reverts commit 1182360.
* made identity-service-logs page infinite scrollable

* made identity-service-logs page infinite scrollable

* made changes for feature flag

---------

Co-authored-by: Amit Prakash <[email protected]>
@listiclehub1
Copy link
Contributor

listiclehub1 commented Sep 25, 2024

Issue Ticket Number

PR's going in this sync

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1

Tested in staging.

staging_demo.mp4

@sahsisunny

@DeltaDynamo
Copy link
Contributor

Issue Ticket Number

PR's going in this sync

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1
RDSTesting.mp4

Screenshot (114)

Mobile View

cc: @sahsisunny

@Achintya-Chatterjee Achintya-Chatterjee marked this pull request as ready for review September 25, 2024 18:21
@iamitprakash iamitprakash merged commit 54d230b into main Sep 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants