Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Dashboard Site Homepage #817

Merged
merged 8 commits into from
Sep 21, 2024

Conversation

Nikhil-Kumar1
Copy link
Contributor

@Nikhil-Kumar1 Nikhil-Kumar1 commented Sep 7, 2024

Date: 07 Sep 2024

Developer Name: Nikhil Kumar

Issue Ticket Number: #808

Description

  1. Improved styling of the Dashboard page and added description.
  2. Improved the hover effect and the colour.

Screenshots

Image after changes-
image

Image before changes-
image

Copy link
Member

@iamitprakash iamitprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Details are missing

style.css Outdated Show resolved Hide resolved
@pallabez
Copy link
Contributor

pallabez commented Sep 15, 2024

The cards font weight looks too strong. Can we take the reference from /groups?
image

<div class="card">
        <h5 class="card__title">Too Much Truth</h5>
        <p class="card__description">Please ask the role creator or admin to update this group description.</p>
</div>
    
.card {
     background: rgb(235, 235, 235);
     padding: 20px;
     border-radius: 15px;
     border: 1px solid hsla(0, 0%, 92%, 1);
     box-shadow: 1px 2px 4px 0px hsla(0, 0%, 0%, 0.1);
}

.card__title {
  font-size: 1.1rem;
  font-weight: 600;
}

.card__description {
  margin-top: 0.6rem;
  color: rgba(54, 54, 54, 0.75);
  font-weight: 400;
  font-size: 0.8rem;
  line-height: 18px;
}

@pallabez
Copy link
Contributor

Thanks for changing the font weight. Can we do the same for box shadow and font color? Also would recommend to remove the hover effect. What do you think?

@Nikhil-Kumar1
Copy link
Contributor Author

Nikhil-Kumar1 commented Sep 15, 2024 via email

@pallabez
Copy link
Contributor

pallabez commented Sep 17, 2024

Discussed

      <a
        class="card"
        href="/goal/index.html"
        id="create-goal"
      >
        <h5 class="card__title">Create Goals</h5>
        <p class="card__description">
          Set and track goals to align efforts and measure progress.
        </p>
      </a>
.card {
  background-color: white;
  text-decoration: none;
  padding: 20px;
  width: 300px;
  border-radius: 15px;
  border: 1px solid hsla(0, 0%, 92%, 1);
  box-shadow: 1px 2px 4px 0px hsla(0, 0%, 0%, 0.1);
}

.card__title {
  margin: 0;
  font-size: 1.1rem;
  font-weight: 600;
  color: hsla(0, 0%, 21%, 1);
}

.card__description {
  margin-top: 0.6rem;
  color: hsla(0, 0%, 21%, 0.75);
  font-weight: 400;
  font-size: 0.8rem;
  line-height: 18px;
}

@Nikhil-Kumar1
Copy link
Contributor Author

Details are missing

previously I had written commit01,02,03, but after that I have started mentioning the details, could you please check once.

@pallabez pallabez merged commit 1182360 into Real-Dev-Squad:develop Sep 21, 2024
4 checks passed
vinit717 added a commit that referenced this pull request Sep 22, 2024
iamitprakash pushed a commit that referenced this pull request Sep 22, 2024
Revert "Improve Dashboard Site Homepage (#817)"

This reverts commit 1182360.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants