Fix application modal and routing #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ashboard into fix/modal-for-particular-application
Deploying dashboard-rds with
|
| Latest commit: |
5d8c5ad
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d3ed2527.dashboard-rds.pages.dev |
| Branch Preview URL: | https://fix-modal-for-particular-app.dashboard-rds.pages.dev |
vinit717
changed the title
|
For test fix and enhancement here is the issue ticket |
Achintya-Chatterjee
previously approved these changes
Aug 21, 2024
yesyash
reviewed
Aug 21, 2024
* fix: Application by id page - Add id in query params when view details btn is clicked - When url with id query param is opened, apps should load applications in background * fix: Status filter on applications page - Check the selected filter value when page with applied filter is reloaded - Remove status query param from url when status filter is cleared * fix: Overflowing text in application cards * Hidden elements should not be rendered on applications page * fix: Add necessary spacing on applications page * Add/update tests for applications page * Replace history state instead of push state on applications page
joyguptaa
reviewed
Aug 27, 2024
joyguptaa
previously approved these changes
Aug 27, 2024
Achintya-Chatterjee
requested changes
Aug 27, 2024
There was a problem hiding this comment.
@samarpan1738 please add test cases screen shots, it's mandatory in every PR
Achintya-Chatterjee
approved these changes
Aug 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Ticket Number
closes #784, #788, #792
Description
Automatic Modal Display: When a superuser navigates to /application?id=, the modal will automatically be displayed.
Button State Management: If the application has already been accepted or rejected, the corresponding action button will be disabled.
Dynamic URL Updates: The URL will update dynamically based on the filters applied, reflecting the selected filter parameters.
API Limit Adjustment: The API has been updated to fetch 6 applications at a time, ensuring that all available space in the application cards is utilized effectively.
Enable applications button on dashboard page
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
790-full-demo.mp4