Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : fixed the broken UI of discord users in mobile view with some UI enhancements. #551

Merged

Conversation

ankitbajpai65
Copy link
Contributor

@ankitbajpai65 ankitbajpai65 commented Oct 9, 2023

Issue - #540

Description -

Under the issue mentioned above, I have fixed the broken UI of discord users in mobile view which negatively impacts the overall user experience and added the footer. Along with this, I have done some enhancement with the UI as well. Please take a look to below added video and screenshots to know more about the changes.

Video after change -

Document.-.Google.Chrome.2023-10-09.15-13-06.1.mp4

Screenshots

Before -

image

image

After -

image
image
image

Test Coverage

image
image

users/discord/style.css Outdated Show resolved Hide resolved

@media only screen and (max-width: 600px) {
main {
display: flex !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may i know the use case for using !important here ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kotesh-arya Missed to remove this. Please check I have done the new changes.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 9, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9d71a73
Status: ✅  Deploy successful!
Preview URL: https://1be72a96.dashboard-rds.pages.dev
Branch Preview URL: https://fix-fix-the-broken-ui-of-dis.dashboard-rds.pages.dev

View logs

Copy link
Member

@iamitprakash iamitprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test case stats..?

@ankitbajpai65
Copy link
Contributor Author

ankitbajpai65 commented Oct 10, 2023

test case stats..?

@iamitprakash Added, please check

@kotesh-arya
Copy link
Contributor

test case stats..?

@iamitprakash Added, please check

If you observe the tests coverage stats you have added in the description they are for the mock-data
Please verify @ankitbajpai65

@kotesh-arya
Copy link
Contributor

kotesh-arya commented Oct 11, 2023

The build is failing, do fix it 👍🏻
you can use this commend and fix it up
yarn prettier --write .

@ankitbajpai65
Copy link
Contributor Author

The build is failing, do fix it 👍🏻 you can use this commend and fix it up yarn prettier --write .

This one is fixed

@ankitbajpai65
Copy link
Contributor Author

test case stats..?

@iamitprakash Added, please check

If you observe the tests coverage stats you have added in the description they are for the mock-data Please verify @ankitbajpai65

@iamitprakash @kotesh-arya Added the tests, please check and approve this pr.

Copy link
Member

@Achintya-Chatterjee Achintya-Chatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:rocket:

@iamitprakash iamitprakash merged commit 1494836 into develop Oct 14, 2023
5 checks passed
@iamitprakash iamitprakash deleted the Fix/fix-the-broken-UI-of-discord-users-in-mobile-view branch October 14, 2023 22:13
@Achintya-Chatterjee Achintya-Chatterjee mentioned this pull request Oct 15, 2023
11 tasks
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants