-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix : fixed the broken UI of discord users in mobile view with some UI enhancements. #551
Fix : fixed the broken UI of discord users in mobile view with some UI enhancements. #551
Conversation
…ashboard into Fix/fix-the-broken-UI-of-discord-users-in-mobile-view
users/discord/style.css
Outdated
|
||
@media only screen and (max-width: 600px) { | ||
main { | ||
display: flex !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may i know the use case for using !important
here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kotesh-arya Missed to remove this. Please check I have done the new changes.
…ashboard into Fix/fix-the-broken-UI-of-discord-users-in-mobile-view
Deploying with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test case stats..?
@iamitprakash Added, please check |
If you observe the tests coverage stats you have added in the description they are for the mock-data |
The build is failing, do fix it 👍🏻 |
This one is fixed |
…ashboard into Fix/fix-the-broken-UI-of-discord-users-in-mobile-view
@iamitprakash @kotesh-arya Added the tests, please check and approve this pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM:rocket:
Issue - #540
Description -
Under the issue mentioned above, I have fixed the broken UI of discord users in mobile view which negatively impacts the overall user experience and added the footer. Along with this, I have done some enhancement with the UI as well. Please take a look to below added video and screenshots to know more about the changes.
Video after change -
Document.-.Google.Chrome.2023-10-09.15-13-06.1.mp4
Screenshots
Before -
After -
Test Coverage