-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: overdue tasks #419
base: develop
Are you sure you want to change the base?
feat: overdue tasks #419
Conversation
Deploying with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put your feature behind feature flag
Also I will request you to show the output of the feature, how to do reviewer know the things you are doing in your feature returns successful output
I Have added the video above only, is it not enough? |
I am not able to see the ouptu
After unassigning the task to the user how can I know if the task has been unassigned or not... NIT - if I click on the unassign button then only the modal should open and we should be able to all the working functionality, I don't think we should have two buttons for it one for unassigning and another for creating an extension request. |
Also put your feature behind feature flag please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please divide your PR into parts, initially it's very long for me to review and also please include tests and coverage without r them I wont be able to review your PR
dismissing self review as this task is re-assigned to me
Overdue tasks feature
2023-08-22.00-01-59.mp4
RFC - #300