Fix prettier, eslint, styelint and make pre commit hooks run #174
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
if |
|
@isVivek99 , There is no difference between the You can verify that by checking how many lines have been changed. If I have emptied out the |
| @@ -35,6 +35,7 @@ export const Button: React.FC<ButtonProps> = ({ | |||
| : 'bg-white border-gray-400 text-gray-900 hover:bg-gray-300' | |||
| } | |||
| ${ | |||
| // eslint-disable-next-line no-nested-ternary | |||
There was a problem hiding this comment.
why disable eslint here?
|
Please address conflicting change and comment on eslint part |
| @@ -35,6 +35,7 @@ export const Button: React.FC<ButtonProps> = ({ | |||
| : 'bg-white border-gray-400 text-gray-900 hover:bg-gray-300' | |||
| } | |||
| ${ | |||
| // eslint-disable-next-line no-nested-ternary | |||
There was a problem hiding this comment.
Could you address this comment please
| export const getEvents = ( | ||
| HOST: string, | ||
|
|
||
| // eslint-disable-next-line default-param-last |
| @@ -1 +1,2 @@ | |||
| // eslint-disable-next-line no-useless-escape | |||
What is the change?
There were a lot of erros and warnings from eslint and stylelint, some files are not formatted correctly using prettier. I have fixed all those.
Refer #179
Is it bug?
No it is not a bug
*Dev Tested?
I have run
yarn teston my local machine. Every test has passed*Tested on:
Platforms
Browsers
I have only run
yarn testBefore / After Change Screenshots
None