Dev to Main Sync #2312
Open
Dev to Main Sync #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdate (#2256) * Added test for id filterin in addOrUpdate * Added Tests for Unobfuscated details and filtered id * Updated test to match fixture instead of Regex * Added test for id filterin in addOrUpdate * Added Tests for Unobfuscated details and filtered id * Updated test to match fixture instead of Regex * Removed comments * Test Cases Added * Added nested profileDiff --------- Co-authored-by: Prakash Choudhary <[email protected]> Co-authored-by: Achintya Chatterjee <[email protected]>
* feat: added pagination for lazy loading in the /groups route to load the discord groups asynchrounously instead of all at once * feat: Implement pagination for lazy loading in - Added feature-flag-based () lazy loading to . - Introduced support for , , and __TEXT __DATA __OBJC others dec hex query parameters for pagination. - Validated query parameters and returned structured pagination metadata (, __TEXT __DATA __OBJC others dec hex, , ). - Updated response structure to include enriched group membership information. - Modified test cases in : - Added tests for cursor-based lazy loading behavior. - Handled scenarios with and without cursors. - Verified error handling for database query failures. * fix: test cases * fix: correct paginated group roles endpoint and dynamic link generation - Fixed incorrect and link generation in the endpoint. - Ensured dynamically includes the correct path (). - Dynamically constructed and links using and . - Refactored function: - Simplified conditional logic for feature flag. - Added error handling for invalid page and size parameters. - Removed hardcoding of URLs in response links to make them adaptive to the environment. - Improved logging for easier debugging when issues arise. - Added handling to ensure old behavior (non-dev mode) works as expected. * chore remove test from here as moving tests in a different PR * fix: failing tests
* Updated the userId Patch endpoint to allow authenticated User patch * added one test case for unauthorized user and superuser
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
vikasosmium
requested review from
iamitprakash,
prakashchoudhary07 and
yesyash
Staging Evidence - #2313Pic 1
Pic 2
Pic 3
Pic 4
Pic 5
|
* feat: added pagination for lazy loading in the /groups route to load the discord groups asynchrounously instead of all at once * feat: Implement pagination for lazy loading in - Added feature-flag-based () lazy loading to . - Introduced support for , , and __TEXT __DATA __OBJC others dec hex query parameters for pagination. - Validated query parameters and returned structured pagination metadata (, __TEXT __DATA __OBJC others dec hex, , ). - Updated response structure to include enriched group membership information. - Modified test cases in : - Added tests for cursor-based lazy loading behavior. - Handled scenarios with and without cursors. - Verified error handling for database query failures. * fix: test cases * fix: correct paginated group roles endpoint and dynamic link generation - Fixed incorrect and link generation in the endpoint. - Ensured dynamically includes the correct path (). - Dynamically constructed and links using and . - Refactored function: - Simplified conditional logic for feature flag. - Added error handling for invalid page and size parameters. - Removed hardcoding of URLs in response links to make them adaptive to the environment. - Improved logging for easier debugging when issues arise. - Added handling to ensure old behavior (non-dev mode) works as expected. * test: added test for the validateLazyLoadingParams * chore remove test from here as moving tests in a different PR * fix: failing tests * test: added test for getPaginatedGroupRolesByPage model functions * test: add tests for getPaginatedAllGroupRoles function in the controller * chore: remove comments from the code --------- Co-authored-by: Vikas Singh <[email protected]>
* added google auth and its tests * added test for fetch call to github api * added feature flag and refactored code * refactored google callback function and some error checks * added test for developer role and checks for email from oauth * added Error messages for emails and their tests * used devflag middleware and add handling redirect url to separate function * changed test names and made stub to function * made cookie options to a function --------- Co-authored-by: Achintya Chatterjee <[email protected]> Co-authored-by: Prakash Choudhary <[email protected]> Co-authored-by: Vikas Singh <[email protected]>
* updated userId route for self patch request based on userid * removed console line * added feature flag * return res fix
* added one patch route for self task assignment based on skillset * test case assertion fix * test case assertion fix
* added one new patch route for tasks status updates * added one new patch route for tasks status updates
21 tasks
Staging Evidence - #2316
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date:
December 22, 2024Developer Name: @Achintya-Chatterjee @vikasosmium @RahulGoyal-tech
Issue Ticket Number
PRs going in this sync
Description
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
-
without dev flag /discord-actions/groupsScreen.Recording.2024-12-24.at.18.23.30.mov
Screen.Recording.2024-12-24.at.18.26.34.mov
Test Coverage
Screenshot 1
Additional Notes