Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev to main sync #2302

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Dev to main sync #2302

merged 2 commits into from
Dec 18, 2024

Conversation

rishirishhh
Copy link
Member

@rishirishhh rishirishhh commented Dec 18, 2024

Date: 18 Dec 2024

Developer Name: Kavya Rishi @vikasosmium


Issue Ticket Number

PR going into the sync

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1 Screenshot 2024-12-18 at 11 19 25 PM Screenshot 2024-12-18 at 11 19 52 PM

rishirishhh and others added 2 commits December 18, 2024 23:05
* fix: deprecated GET task/self

* fix: fixed the failing test

* Update tasks.test.js

* added warning message for deprecated route

* added test cases for dev = false or when dev is not present

* added a new error message

* added error message to the controller

* changes to the error code in test

* correct warning message

* Update tasks.test.js

* Update tasks.test.js

* added new warning message

* test changes

* Merge pull request #2292 from vikasosmium/deprecate-stocks-self-GET-route

Added New Route to fetch User Stocks

* Remove user.data() in firestore data set (#2282)

* Updated set

* Added Dev Feature Flag

* Added variable for dev flag

* Update dev feature flag to be used as boolean

* Tests working of addOrUpdate feature when dev feature flag is true

---------

Co-authored-by: Achintya Chatterjee <[email protected]>
Co-authored-by: Prakash Choudhary <[email protected]>

* new route definition

minor changes

* Update tasks.js

* reverted errorMessages.ts

* reverted tasks.js controller

* reverted tasks.js router

* updated tasks.test.js

---------

Co-authored-by: Vikas Singh <[email protected]>
Co-authored-by: Rahul Goyal <[email protected]>
Co-authored-by: Achintya Chatterjee <[email protected]>
Co-authored-by: Prakash Choudhary <[email protected]>
* added one put api for user intro

* route checking fix

* deprecate message comment

* fixed test cases

* added one userauthorization middleware and test cases fixes

* added userAuthorization middleware

* Revert "added one userauthorization middleware and test cases fixes"

This reverts commit 7dcd885.

* Revert "Revert "added one userauthorization middleware and test cases fixes""

This reverts commit 238cd17.

* fixed test case msg

---------

Co-authored-by: Achintya Chatterjee <[email protected]>
Co-authored-by: Rishi <[email protected]>
@vikasosmium
Copy link
Contributor

vikasosmium commented Dec 18, 2024

Staging Evidence #2293

1

Screenshot (6)

2

Screenshot (7)

3

Screenshot (8)

4

Screenshot (9)

@vikasosmium vikasosmium requested a review from yesyash December 18, 2024 18:57
@prakashchoudhary07 prakashchoudhary07 merged commit f699cdc into main Dec 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants