Updated the logic to return 404 instead of 200 when wrong taskRequest Id is sent #2296
+61
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please check if we have tets written for this, if yes then how are they passing before |
|
Also can we please improve the title and PR description |
Akshat187
changed the title
+1 |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Update the API Contract and link it here for the error codes and other changes. |
|
add tests SS |
pankajjs
reviewed
Dec 20, 2024
pankajjs
reviewed
Dec 20, 2024
|
Add test coverage |
updated the error message |
I have kept test coverage screenshot in the Description |
|
Real-Dev-Squad/website-api-contracts#207 API contract changes |
vikhyat187
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 14-12-24
Developer Name: akshat
Issue Ticket Number
(#2290 )
Description
When queried with taskRequestId which doesn't exist,
fetchTaskRequestByIdwas returningTasks returned successfullyinstead ofTask request not found, have changed the code to return the proper error message, currently there are no tests for this case, so it didn't get highlighted.Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Current implementation returning 200 OK, even when the id is incorrect
Updated implementation to return `Task request not found` when wrong id is passed
Test Coverage
Screenshot 1
unit test coverage
Additional Notes