Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev to Main Sync #2283

Merged
merged 32 commits into from
Dec 7, 2024
Merged

Dev to Main Sync #2283

merged 32 commits into from
Dec 7, 2024

Conversation

vinit717 and others added 23 commits October 30, 2024 00:38
* feat: orphaned tasks API changes.

* feat: Added tests for orphaned tasks.

* chore: Returned without a block for usersnaptop empty and added spacing to make it more readable.

* Refactor: Update fetchOrphanedTasks to use batch query for incomplete tasks

- Replaced individual queries with `fetchIncompleteTasksByUserIds` to fetch tasks in batch for users not in the Discord server.
- Improved performance by reducing the number of database queries.
- Modified testcases based on the updates.

* fix: Changed abandoned tasks to orphaned tasks.

* Fix: Changed the validation type of orphaned to boolean instead of string.
…2268)

* feat: Departed users api changes.

* feat: Added test cases for departed users api changes.

* Refactor: Update fetchIncompleteTasksByUserIds to use batch queries and filter in-memory

- Replaced Firestore query with batch query to fetch incomplete tasks for multiple users at once.
- Filter tasks by user IDs and completed statuses in-memory for improved efficiency.
- Updated return structure to return an array directly instead of an object with `docs` property.
- Updated test cases related to the same.
Added function for unobfuscated profileDiffs, filtered id while updating profileDiffs
…2271)

* Fix: change env variables from obj to string

This resolves the error faced in staging for the discord command developed by me /grant-aws-access, we were facing this issue when running this in stgaging, this is becuase in the node-config the values were being set as obj with name field as the actual value

* lint-fix

* removing console log statement

* removing the extra log

* handling conflict case, where user with email already exists in AWS
* add unverified role to db and remove on /verify

* destructured role and variable naming

* fix: generic logs and removed unnecessary statement

* refactor: improve error handling and logging in removeDiscordRoleFromUser function

* refactor: simplify error message handling

* batch db insertion

* changed to typescript and modified unit tests
…pdate field name from 'assigneeId' to 'assignee' (#2279)
vinit717 and others added 4 commits December 5, 2024 01:01
* chore: fix log type into lower case

* chore: revert changes for make the logs working

* chore: add logs migration route

* chore: add migration model function

* chore: add tests for migration api

* chore: update route name

* chore: update route name
* chore : fix logs meta field to use userId

* chore: fix task log
routes/logs.js Dismissed Show dismissed Hide dismissed
@vinit717
Copy link
Member

vinit717 commented Dec 5, 2024

Proof for #2226, #2269 and #2248

image
![image](https://github.com/user-attachments/asse
Screenshot 2024-12-06 at 6 55 56 PM
ts/6549a787-1473-4546-9076-f6c67a127710)
Screenshot 2024-12-06 at 6 57 48 PM

@VaibhavSingh8
Copy link
Contributor

VaibhavSingh8 commented Dec 5, 2024

Proof for #2281

staging-proof.mp4

@shobhan-sundar-goutam
Copy link
Contributor

Proof for #2257

store-delete-unverified-db-staging.mp4

* added new route to fetch user art

* added new route under featureflag

* added test cases for new route

* wrote 2 new test cases and and one no content cond.

* removing feature flag
@VinuB-Dev
Copy link
Contributor

Proof for #2267 and #2268

#2267:

Screenshot 2024-12-06 at 8 33 21 AM
Screenshot 2024-12-06 at 8 36 54 AM

#2268:

Screenshot 2024-12-06 at 8 35 07 AM
Screenshot 2024-12-06 at 8 36 15 AM

@vikasosmium
Copy link
Contributor

Staging Evidence #2289

image

@prakashchoudhary07 prakashchoudhary07 merged commit 32ebdc3 into main Dec 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants