Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Firestore query limit issue for departed users and orphaned tasks APIs #2279

Merged

Conversation

VinuB-Dev
Copy link
Contributor

@VinuB-Dev VinuB-Dev commented Dec 2, 2024

Date: 03/12/2024
Developer Name: Vignesh B S


Issue Ticket Number

Closes Real-Dev-Squad/website-dashboard#888

Description

  • Resolved the Firestore query limit issue when fetching orphaned tasks and departed users.
  • Updated the field name from assigneeId to assignee to ensure consistency.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1

Departed users API:
Screenshot 2024-12-03 at 1 00 32 AM

Orphaned Tasks API:
Screenshot 2024-12-03 at 1 00 51 AM

Test Coverage

Screenshot 1 Screenshot 2024-12-03 at 12 59 50 AM

Additional Notes

The API was failing with a 500 status due to Firebase's in operator, which supports a maximum of 30 elements in the array. An error is thrown if the array exceeds this limit. This issue has been resolved in this PR.

Relates to:
#2268
#2267

…pdate field name from 'assigneeId' to 'assignee'
@vinit717
Copy link
Member

vinit717 commented Dec 4, 2024

please fix the title name

@VinuB-Dev
Copy link
Contributor Author

please fix the title name

Should I change it?
This PR is a fix for the APIs I had added earlier, as mentioned in the title and description.

@VinuB-Dev VinuB-Dev changed the title Fix: Resolve Firestore query limit issue for /users?departed=true and /tasks?orphaned=true API's Fix: Firestore query limit issue for departed users and orphaned tasks APIs Dec 4, 2024
@iamitprakash iamitprakash merged commit 46bc908 into Real-Dev-Squad:develop Dec 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement APIs for Tracking Orphaned Tasks and Departed Users.
4 participants