generated from Real-Dev-Squad/website-template
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev To Main #2260
Merged
Merged
Dev To Main #2260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add logs when user doc is updated * chore: remove query from api * chore: fix addlog when user doc is updated * chore: fix circular dependency * chore: fix failing test * chore: remove extra changes * chore: add integration test * chore: add test for log service
* aws setup * lint-fix * fixed linting issues * Removed the flow to take credentials from .aws folder in local * resolving merge conflicts * added unit tests for the code * aws setup * Revert "aws setup" This reverts commit e447b63. * added integration tests * refactored the route and removed console log * updated the integration tests and added fixture * changes 1. Fixed all integration tests 2. changed error status to 400 3. removed unnessary code: * resolving PR comments * resolving PR comments * Fixed test cases and added test case for User not found case * added feature flag to backend API and updated test cases * Changes 1. changed route to /aws/groups/access 2. refactored code * code refactor and removed one comment * Returning the error response to the user * refactored the condition --------- Co-authored-by: Achintya Chatterjee <[email protected]> Co-authored-by: Prakash Choudhary <[email protected]>
* added new route to fetch user art * added new route under featureflag * added test cases for new route * wrote 2 new test cases and and one no content cond.
* Fix: change env variables from obj to string This resolves the error faced in staging for the discord command developed by me /grant-aws-access, we were facing this issue when running this in stgaging, this is becuase in the node-config the values were being set as obj with name field as the actual value * Lint-fix, removed extra line
Proof for PR - #2182 |
* feat: add unit tests for authentication middelware * fix: add missing config import statement * feat: add more expectation for test cases * fix: refactor set cookies and add assertions in stubs
* added route, controller and model for deleting the group role * added route, controller and model for deleting the group role * unit tests for deleteGroupRole * updated unit tests for deleteGroupRole * integrated feature flag * chore: roleid fetch from firestore and removed console logs * integration tests for deleteGroupRole * fix: reduced db calls from 2 to 1 for roleId * feat: integrated discord service to delete role from discord * test: unit and integration tests for discord service integration * chore: refactored controller and tests to use res.boom and routes to use devFlag middleware * fix: error code
iamitprakash
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 20-Nov-2024
Developer Name: @vikasosmium @vikhyat187 @vinit717
Issue Ticket Number
Closes
PR List
Description
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Granting AWS discord command #2208
Output from RDS test server - command ran by Tejas
Additional Notes
Deployment Steps for Grant AWS command #2250