Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug : Added checks to validate user groups #1942

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

joyguptaa
Copy link
Contributor

@joyguptaa joyguptaa commented Mar 6, 2024

Date: 6 March 2024
Developer Name: Joy Gupta


Issue Ticket Number

Description

This PR contains 2 fixes.

  1. Users cannot add roles that are not stored in the database.
  2. If a role is stored in the database, users can only add those with a group prefix.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screen.Recording.2024-03-06.at.8.58.48.PM.1.mov

Test Coverage

Screenshot 2024-03-06 at 1 00 13 PM

Additional Notes

The failing test case is also failing on locally and has nothing to do with my changes.

Screenshot 2024-03-07 at 12 10 21 AM

@iamitprakash iamitprakash merged commit 6e9f5c1 into develop Mar 7, 2024
2 of 3 checks passed
@iamitprakash iamitprakash deleted the bugFix/discord-role-vulnerability branch March 7, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants