add: validation to createFetureFlag api

Real-Dev-Squad · Nov 25, 2024 · f669133 · f669133
1 parent 7bf47cd
commit f669133
Show file tree

Hide file tree

Showing 4 changed files with 35 additions and 8 deletions.
diff --git a/controllers/featureFlags.ts b/controllers/featureFlags.ts
@@ -72,7 +72,6 @@ export const createFeatureFlag = async (req: CustomRequest, res: CustomResponse)
 export const updateFeatureFlag = async (req: CustomRequest, res: CustomResponse) => {
   try {
     const { flagId } = req.params;
-    console.log("Mehulllll", flagId)
     const updateData: UpdateFeatureFlagRequestBody = {
       Status: req.body.Status,
       UserId: req.body.UserId,

diff --git a/middlewares/validators/featureFlag.ts b/middlewares/validators/featureFlag.ts
@@ -25,4 +25,32 @@ export const validateUpdateFeatureFlag = async (req: Request, res: CustomRespons
     logger.error(`Error validating update feature flag payload: ${error.message}`);
     res.boom.badRequest(error.message);
   }
-}; 
+};
+
+const createFeatureFlagSchema = Joi.object({
+	Name: Joi.string()
+		.required()
+		.messages({
+			'any.required': 'Name is required'
+		}),
+	Description: Joi.string()
+		.required()
+		.messages({
+			'any.required': 'Description is required'
+		}),
+	UserId: Joi.string()
+		.required()
+		.messages({
+			'any.required': 'UserId is required'
+		})
+});
+
+export const validateCreateFeatureFlag = async (req: Request, res: CustomResponse, next: NextFunction) => {
+	try {
+		await createFeatureFlagSchema.validateAsync(req.body);
+		next();
+	} catch (error) {
+		logger.error(`Error validating create feature flag payload: ${error.message}`);
+		res.boom.badRequest(error.message);
+	}
+};
diff --git a/routes/featureFlag.ts b/routes/featureFlag.ts
@@ -2,13 +2,13 @@ import express from "express";
 const router = express.Router();
 import authenticate from "../middlewares/authenticate";
 const authorizeRoles = require("../middlewares/authorizeRoles");
-import { createFeatureFlag, getAllFeatureFlags, getFeatureFlagById, updateFeatureFlag} from "../controllers/featureFlags";
+import { createFeatureFlag, getAllFeatureFlags, getFeatureFlagById, updateFeatureFlag } from "../controllers/featureFlags";
 const { SUPERUSER } = require("../constants/roles");
-import { validateUpdateFeatureFlag } from '../middlewares/validators/featureFlag';
+import { validateUpdateFeatureFlag, validateCreateFeatureFlag } from '../middlewares/validators/featureFlag';
 
 router.get("/getAllFeatureFlags", authenticate, getAllFeatureFlags);
 router.get("/getFeatureFlag/:flagId", authenticate, getFeatureFlagById);
-router.post('/createFeatureFlag', authenticate, authorizeRoles([SUPERUSER]), createFeatureFlag);
+router.post('/createFeatureFlag', authenticate, authorizeRoles([SUPERUSER]), validateCreateFeatureFlag, createFeatureFlag);
 router.patch('/updateFeatureFlag/:flagId', authenticate, authorizeRoles([SUPERUSER]), validateUpdateFeatureFlag, updateFeatureFlag);
 
-module.exports = router;
+module.exports = router;
diff --git a/services/featureFlagService.ts b/services/featureFlagService.ts
@@ -62,12 +62,12 @@ const updateFeatureFlag = async (
     updateData: UpdateFeatureFlagRequestBody
 ): Promise<FeatureFlagResponse> => {
     try {
-        const response = await fetch(`http://127.0.0.1:3000/feature-flags/${flagId}`, {
+        const response = await fetch(`${FEATURE_FLAG_BASE_URL}/feature-flags/${flagId}`, {
             method: "PATCH",
             headers: generateHeaders(),
             body: JSON.stringify(updateData),
         });
-        console.log("Mehulllll", response)
+
         if (!response.ok) {
             const error = await response.json();
             return {