Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the failing CI github workflow #8

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

samarpan1738
Copy link
Contributor

@samarpan1738 samarpan1738 commented Dec 20, 2024

Date: 20 Dec 2024

Developer Name: Samarpan Harit


Issue Ticket Number

Description

  • The CI github workflow is failing in python requirements installation phase (Link)
  • Removed the redundant container definition from the Github workflow since it's conflicting with actions/setup-python@v4
  • We were configuring python with container definition and actions/setup-python@v4 leading to this issue.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

The workflow successfully running for this PR is the proof of it's working

Success workflow execution for this PR Screenshot 2024-12-20 at 11 36 27 PM

Test Coverage

Not applicable

Additional Notes

This was causing error while installing python requirements. It's conflicting with `actions/setup-python@v4`
Copy link
Member

@iamitprakash iamitprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please mention reason why it was added in first place, if possible add reference

@samarpan1738
Copy link
Contributor Author

please mention reason why it was added in first place, if possible add reference

I had generated the github workflow file using ChatGPT and tested it and it was working earlier.

Acc. to my findings, the workflow fails when the base runner image is ubuntu-24.04 but passes when it is ubuntu-22.04.5. We have specified ubuntu-latest as the base runner image
But Github has recently (Dec 5th) started migration of ubuntu-latest label from ubuntu 22 to ubuntu 24. Link

Acc. to this github issue, they have removed some of the packages and changed versions of few packages in ubuntu 24 image.

A combination of base runner image ubuntu-24.04, container image python:3.12-slim-bookworm and actions/setup-python@v4 is leading to the failure of the workflow.
Error message :
python3.12: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.38' not found (required by /__t/Python/3.12.8/x64/lib/libpython3.12.so.1.0)

Using actions/setup-python@v4 is enough to setup the correct python version and install all of it's required dependencies

iamitprakash
iamitprakash previously approved these changes Dec 24, 2024
@iamitprakash iamitprakash self-requested a review December 24, 2024 19:53
@iamitprakash
Copy link
Member

please mention reason why it was added in first place, if possible add reference

I had generated the github workflow file using ChatGPT and tested it and it was working earlier.

Acc. to my findings, the workflow fails when the base runner image is ubuntu-24.04 but passes when it is ubuntu-22.04.5. We have specified ubuntu-latest as the base runner image But Github has recently (Dec 5th) started migration of ubuntu-latest label from ubuntu 22 to ubuntu 24. Link

Acc. to this github issue, they have removed some of the packages and changed versions of few packages in ubuntu 24 image.

A combination of base runner image ubuntu-24.04, container image python:3.12-slim-bookworm and actions/setup-python@v4 is leading to the failure of the workflow. Error message : python3.12: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.38' not found (required by /__t/Python/3.12.8/x64/lib/libpython3.12.so.1.0)

Using actions/setup-python@v4 is enough to setup the correct python version and install all of it's required dependencies

why this @v4

    - name: Set up Python
        uses: actions/setup-python@v4
        with:
          python-version: '3.12'

@samarpan1738

@samarpan1738
Copy link
Contributor Author

samarpan1738 commented Dec 24, 2024

please mention reason why it was added in first place, if possible add reference

I had generated the github workflow file using ChatGPT and tested it and it was working earlier.
Acc. to my findings, the workflow fails when the base runner image is ubuntu-24.04 but passes when it is ubuntu-22.04.5. We have specified ubuntu-latest as the base runner image But Github has recently (Dec 5th) started migration of ubuntu-latest label from ubuntu 22 to ubuntu 24. Link
Acc. to this github issue, they have removed some of the packages and changed versions of few packages in ubuntu 24 image.
A combination of base runner image ubuntu-24.04, container image python:3.12-slim-bookworm and actions/setup-python@v4 is leading to the failure of the workflow. Error message : python3.12: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.38' not found (required by /__t/Python/3.12.8/x64/lib/libpython3.12.so.1.0)
Using actions/setup-python@v4 is enough to setup the correct python version and install all of it's required dependencies

why this @v4

    - name: Set up Python
        uses: actions/setup-python@v4
        with:
          python-version: '3.12'

@samarpan1738

I had picked it up from a code sample from an article and not from the official docs. Therefore it's an older (v4) version
I have changed it to v5 (latest version)

with:
python-version: '3.12'
python-version: '3.12.7'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we can't go with something like 3.12.* like we do have in others repo even in frontend repos

Copy link
Contributor Author

@samarpan1738 samarpan1738 Dec 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it to 3.12.*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants