Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add health check route #87

Merged
merged 2 commits into from
Jan 29, 2024
Merged

feat: add health check route #87

merged 2 commits into from
Jan 29, 2024

Conversation

iRohitGaur
Copy link
Contributor

Issue Ticket Number

#85

Description

  • Added Health check route
  • Added unit test for health check

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 2024-01-27 at 12 50 46

Test Coverage

Screenshot 2024-01-27 at 12 49 53

Additional Notes

@iRohitGaur iRohitGaur self-assigned this Jan 28, 2024
prakashchoudhary07
prakashchoudhary07 approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@prakashchoudhary07 prakashchoudhary07 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, We can merge it after one more approval

bhtibrewal
bhtibrewal reviewed Jan 29, 2024
View reviewed changes
Copy link
Contributor

@bhtibrewal bhtibrewal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay to merge after @debanjanc01's approval

@debanjanc01
Copy link
Contributor

Okay to merge after @debanjanc01's approval

@debanjanc01 debanjanc01 reopened this Jan 29, 2024
@debanjanc01
Copy link
Contributor

@iRohitGaur closed it by mistake. Have reopened it again.

@iRohitGaur iRohitGaur merged commit c4303c3 into develop Jan 29, 2024
2 checks passed
@iRohitGaur iRohitGaur deleted the irohitgaur-health-check-route branch January 29, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhtibrewal bhtibrewal bhtibrewal approved these changes

@debanjanc01 debanjanc01 debanjanc01 approved these changes

@prakashchoudhary07 prakashchoudhary07 prakashchoudhary07 approved these changes

Assignees

@iRohitGaur iRohitGaur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iRohitGaur @debanjanc01 @prakashchoudhary07 @bhtibrewal