Fixes #114 - Downgrading JWT Libraries as short-term fix for Public Key Size limit #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e limitation issue
akhilkh2000
force-pushed
the
downgrade-jwt-library
branch
from
8a55f94 to
aa906fe
Compare
bhtibrewal
approved these changes
Apr 20, 2024
iamitprakash
approved these changes
Apr 20, 2024
MehulKChaudhari
pushed a commit
to MehulKChaudhari/skill-tree-backend
that referenced
this pull request
May 9, 2024
…Public Key Size limitation issue (Real-Dev-Squad#115)
prakashchoudhary07
added a commit
that referenced
this pull request
May 22, 2024
* added workflow to deploy to ecs * add aws region * add env * fix secret variable name * fix dockerfile path * make mvn executable * fix path dockerfile * fix target path * fix: cluster same * login docker seprately * update aws region * add new cluster * fix cluster name * change cluster name * fix secrets * add workflow file * add env while building * fix image name * add image repo URI in secrets * fix dockerfile path * add workflow file * fix CI to run push * temp: fix to check if deployment works * add deploy to ec2 back * fix ECR public login * fix ECR public URI * fix ecr login command * fix login command * fix dockerfile * fix docker push command * fix tag and push * fix ecr login * fix aws login * fix aws region * fix ecr-public login region * deploy to ec2 * Update deploy-to-ec2.yml * check UI is working or not * fix: broken change * change the action runner * change branch for testing. * instead of script add steps * update readme and tokens for integration test (#104) * update readme * Update README.md Co-authored-by: Satyam Bajpai <[email protected]> * Update README.md Co-authored-by: Satyam Bajpai <[email protected]> * Update README.md Co-authored-by: Satyam Bajpai <[email protected]> * update auth link * update tokens * format code * update public key * update public key * update tokens * fix readme * Update README.md Co-authored-by: Akhil Khubchandani <[email protected]> * address review comments --------- Co-authored-by: Satyam Bajpai <[email protected]> Co-authored-by: Akhil Khubchandani <[email protected]> * (#114)-Downgrading JWT Libraries as short-term fix for Public Key Size limitation issue (#115) * Adding integration tests for endorsement service (#107) * Added integration tests for endorsement service * Added test suite for integration tests * testing separation of unit and integration ci and pomxml * Addressed review comments and added build step in CI * Fix API contract and added pagination assertions to integration tests * Fixing typos and addressing review comments * Addressed review comments * Addressed review comments * Addressed review comments --------- Co-authored-by: akhil <[email protected]> * added implementation for V1 search endorsements based on dummy data * Enabled Unit and Integration tests, Auth whitelist for /v1/endorsements * Formatting fixed * Put dummyData implementation behind dummyData=true feature flag, old flow kept intact, tests updated * formatting fixed * pass public key as env variable * fix: remove extra space * add api v1 prefix and data source version * fix: command format * fix: remove extra env * fix: change branch name --------- Co-authored-by: Achintya Chatterjee <[email protected]> Co-authored-by: Prakash Choudhary <[email protected]> Co-authored-by: Amit Prakash <[email protected]> Co-authored-by: Bhavika Tibrewal <[email protected]> Co-authored-by: Satyam Bajpai <[email protected]> Co-authored-by: Akhil Khubchandani <[email protected]> Co-authored-by: Chethan <[email protected]> Co-authored-by: akhil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 20/04/2024
Developer Name: Akhil Khubchandani
Issue Ticket Number
#114
Description
Downgrading JWT Libraries and required transitive dependancies as short-term fix for #114
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Tested all the GET API's in the project, they are successfully working with the token generated using the 1024 bit public key used on website backend
Screenshots of example API's tested locally
GET endorsements/
GET endorsements/:id
GET skills/
GET skills/:id
GET skills/name/:name
Test Coverage
NA - Not relevant for this PR
Additional Notes
This will need to be upgraded back to the latest package when Real-Dev-Squad/website-backend#2014 is resolved with the long term plan.