fix: match endorsementId with the DB

Real-Dev-Squad · May 12, 2024 · 99349dc · 99349dc
1 parent 0fb19dd
commit 99349dc
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/skill-tree/src/main/java/com/RDS/skilltree/Endorsement/EndorsementController.java b/skill-tree/src/main/java/com/RDS/skilltree/Endorsement/EndorsementController.java
@@ -82,7 +82,7 @@ public ResponseEntity<GenericResponse<EndorsementDTO>> postEndorsement(
 
     @PatchMapping(value = "/{id}")
     public ResponseEntity<GenericResponse<Void>> updateEndorsementStatus(
-            @PathVariable(value = "id") String id, @RequestParam String status) {
+            @PathVariable(value = "id") UUID id, @RequestParam String status) {
         return ResponseEntity.ok().body(endorsementService.updateEndorsementStatus(id, status));
     }
 }
diff --git a/skill-tree/src/main/java/com/RDS/skilltree/Endorsement/EndorsementService.java b/skill-tree/src/main/java/com/RDS/skilltree/Endorsement/EndorsementService.java
@@ -17,5 +17,5 @@ Page<EndorsementModelFromJSON> getEndorsementsFromDummyData(
 
     EndorsementModel createEndorsement(EndorsementDRO endorsementDRO);
 
-    GenericResponse<Void> updateEndorsementStatus(String id, String status);
+    GenericResponse<Void> updateEndorsementStatus(UUID id, String status);
 }
diff --git a/skill-tree/src/main/java/com/RDS/skilltree/Endorsement/EndorsementServiceImpl.java b/skill-tree/src/main/java/com/RDS/skilltree/Endorsement/EndorsementServiceImpl.java
@@ -136,7 +136,7 @@ public EndorsementModel createEndorsement(EndorsementDRO endorsementDRO) {
     }
 
     @Override
-    public GenericResponse<Void> updateEndorsementStatus(String id, String status) {
+    public GenericResponse<Void> updateEndorsementStatus(UUID id, String status) {
         UserModel user =
                 (UserModel) SecurityContextHolder.getContext().getAuthentication().getPrincipal();
         if (!user.getRole().equals(UserRole.SUPERUSER)) {
@@ -146,13 +146,11 @@ public GenericResponse<Void> updateEndorsementStatus(String id, String status) {
                 || status.equals(EndorsementStatus.REJECTED.name()))) {
             throw new InvalidParameterException("endorsement status", status);
         }
-        if (!CommonUtils.isValidUUID(id)) {
-            throw new InvalidParameterException("endorsement id", id);
+        if (!CommonUtils.isValidUUID(id.toString())) {
+            throw new InvalidParameterException("endorsement id", id.toString());
         }
 
-        UUID endorsementId = UUID.fromString(id);
-        Optional<EndorsementModel> optionalEndorsementModel =
-                endorsementRepository.findById(endorsementId);
+        Optional<EndorsementModel> optionalEndorsementModel = endorsementRepository.findById(id);
         if (optionalEndorsementModel.isPresent()) {
             EndorsementModel updatedEndorsementModel =
                     EndorsementModel.builder()