Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove skipped test cases #472

Conversation

abhisheksharmayt
Copy link
Contributor

@abhisheksharmayt abhisheksharmayt commented Oct 22, 2024

Date: 23-10-2024
Developer Name: Abhishek Sharma


Issue Ticket Number

Description

  1. Removed .skip from test cases in util-test.ts test cases.
  2. Updated test cases and their description wherever required as the function implementation was changed but test cases were not updated(Attached Screenshot).
  3. Made sure that all test cases in util-test.ts pass.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1

Screenshot 2024-10-19 002356

Test Coverage

Screenshot 1

image

Additional Notes

There were a lot of test cases that were skipped, so divided it into multiple PR.
PR(1/5).

test('when token passed is invalid, axios call returns with 401', async () => {
mockedAxios.get.mockRejectedValue('401: Unauthorized');
try {
await getUserData(invalidToken);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the function accepting token or userId?

Copy link
Contributor Author

@abhisheksharmayt abhisheksharmayt Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token
image

@iamitprakash iamitprakash merged commit 467121c into Real-Dev-Squad:develop Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Skipped Tests and Ensure Test Suite is Running Fully
3 participants