Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update outdated packages in package.json #463

Merged

Conversation

Aditys018
Copy link
Contributor

Date: 09-10-2024

Developer Name: Aditi Shinde


Issue Ticket Number

#454

Description

This Updates the following packages from the package.json

• async-storage • netinfo • masked-view • axios • prettier • app-auth • tab-view • image-picker • keychain • buttons-group • safe-area-context • react-native-svg • react-redux • align-deps • jest-native • jest • react • react-native • eslint-parser • eslint

Additionally updated DatePicker.tsx for compatibility with the updated dependencies (Refs: #462 )

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1
RDS_Test1.mp4

Test Coverage

Screenshot 1 NA

Additional Notes

Copy link
Contributor

@ashifkhn ashifkhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments;

android/build.gradle Outdated Show resolved Hide resolved
android/gradle.properties Outdated Show resolved Hide resolved
src/components/CreateGoalForm/DatePicker.tsx Outdated Show resolved Hide resolved
@Aditys018 Aditys018 requested a review from ashifkhn October 9, 2024 10:45
android/build.gradle Outdated Show resolved Hide resolved
@Aditys018 Aditys018 changed the title fix(deps): update packages and modify Datepicker.tsx, Refs: #454,462 fix(deps): update outdated packages in package.json Oct 9, 2024
@Aditys018 Aditys018 changed the title fix(deps): update outdated packages in package.json Update outdated packages in package.json Oct 11, 2024
ashifkhn
ashifkhn previously approved these changes Nov 8, 2024
Copy link
Member

@vinit717 vinit717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI build is failing and also add screenshot of working app build

@Aditys018
Copy link
Contributor Author

Aditys018 commented Nov 8, 2024

@vinit717 CI Build is successful.
Recording of the working app here :

RDS_Test4.mp4

package.json Show resolved Hide resolved
@Aditys018
Copy link
Contributor Author

Resolved date-picker comment by @vinit717

RDS_Test5.mp4

@iamitprakash iamitprakash merged commit b81abab into Real-Dev-Squad:develop Nov 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants