Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Utility Functions Using AWS Lambda Layers #216

Merged
merged 9 commits into from
Aug 2, 2024

Conversation

lakshayman
Copy link
Collaborator

@lakshayman lakshayman commented Aug 2, 2024

Date: 02/08/2024

Developer Name: @lakshayman


Issue Ticket Number

#213

Description

Currently, our identity service has five Lambda functions. Each of these Lambda functions uses utility functions that are duplicated across each function. This redundancy increases maintenance effort and the risk of inconsistencies. To address this, we propose using AWS Lambda Layers to consolidate these utility functions in a single location, allowing all Lambda functions to share the same layer.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Test Coverage

Screenshot 1

image

@lakshayman lakshayman marked this pull request as ready for review August 2, 2024 19:14
@lakshayman lakshayman self-assigned this Aug 2, 2024
@lakshayman lakshayman changed the title Enhancement/aws layers Consolidate Utility Functions Using AWS Lambda Layers Aug 2, 2024
Copy link
Member

@MehulKChaudhari MehulKChaudhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, much efficient & DRY code 🔥

@lakshayman lakshayman merged commit 0ee840a into develop Aug 2, 2024
4 checks passed
@lakshayman lakshayman deleted the enhancement/aws-layers branch August 2, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants